hub-client: apply theme on login screen and after logout#229
Merged
Conversation
ThemeProvider was mounted inside App's post-login branches only, so the login screen rendered with no class on <html> (falling back to the light :root defaults) and the dark class persisted on <html> after logout because the provider's useEffect has no cleanup. Hoist ThemeProvider into main.tsx so it wraps every branch of App.
shikokuchuo
force-pushed
the
bugfix/hub-client-login-theme-persist
branch
from
a232a3f to
b799abf
Compare
shikokuchuo
force-pushed
the
bugfix/hub-client-login-theme-persist
branch
from
b799abf to
51dd9b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #228.
ThemeProviderwas mounted inside App's post-login branches only, so the login screen fell back to light defaults (the class set during a prior session persisted on logout because the provider'suseEffecthas no cleanup.ThemeProviderintomain.tsxso it wraps every branch ofApp. SavedcolorSchemeand systemprefers-color-schemenow apply consistently across auth states.