Skip to content

hub-client: apply theme on login screen and after logout #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shikokuchuo merged 2 commits into from
May 21, 2026
Merged

hub-client: apply theme on login screen and after logout #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c84696
hub-client: apply theme on login screen and after logout
shikokuchuo May 21, 2026
51dd9b1
hub-client: changelog for 6c84696d
shikokuchuo May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hub-client/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ be in reverse chronological order (latest first).

-->

### 2026-05-21

- [`6c84696d`](https://github.com/quarto-dev/q2/commits/6c84696d): Login screen and post-logout view now respect the saved `colorScheme` preference (and system `prefers-color-scheme`) instead of always rendering light on first visit and inheriting the previous session's class after logout.

### 2026-05-15

- [`e9399093`](https://github.com/quarto-dev/q2/commits/e9399093): Authorship pill in the replay bar now animates with a rotating rainbow border while attribution data is being generated, so large documents give visible feedback that work is happening before the colours appear in the preview.
Expand Down
11 changes: 3 additions & 8 deletions hub-client/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ function DevHarnessLazy({ page }: { page: string }) {
import Editor from './components/Editor';
import Toast from './components/Toast';
import { ViewModeProvider } from './components/ViewModeContext';
import { ThemeProvider } from './components/ThemeContext';
import { LoginScreen } from './components/auth/LoginScreen';
import {
connect,
Expand Down Expand Up @@ -568,11 +567,7 @@ function App() {
// Dev harness: render components in isolation for visual testing.
// Only available in development builds; the DevRoute type is never parsed in production.
if (route.type === 'dev') {
return (
<ThemeProvider>
<DevHarnessLazy page={route.page} />
</ThemeProvider>
);
return <DevHarnessLazy page={route.page} />;
}

// Show project set setup/migration screen if needed
Expand Down Expand Up @@ -611,7 +606,7 @@ function App() {
}

return (
<ThemeProvider>
<>
{!project ? (
<ProjectSelector
onSelectProject={handleSelectProject}
Expand Down Expand Up @@ -654,7 +649,7 @@ function App() {
visible={showSaveToast}
onHide={() => setShowSaveToast(false)}
/>
</ThemeProvider>
</>
);
}

Expand Down
5 changes: 4 additions & 1 deletion hub-client/src/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import App from './App.tsx'
import { savePreAuthHash, restorePreAuthHash } from './utils/routing'
import { AuthProviderRoot, noopAuthProvider } from './auth/AuthProvider'
import { googleAuthProvider } from './auth/GoogleAuthProvider'
import { ThemeProvider } from './components/ThemeContext'

// Pre-auth hash preservation for the Google OAuth redirect flow.
// On first visit: save the hash (e.g., #/share/...) before React clears it.
Expand All @@ -31,7 +32,9 @@ const authProvider = GOOGLE_CLIENT_ID ? googleAuthProvider : noopAuthProvider;

const root = (
<StrictMode>
<App />
<ThemeProvider>
<App />
</ThemeProvider>
</StrictMode>
);

Expand Down