Fix ipynb rendering an empty title header when no title is set - #14697
Merged
Conversation
title-block.md unconditionally emitted a level-1 markdown header for every ipynb render, even without a title, producing a stray "# " line in the notebook's first cell. Every other title template in the codebase (html, pdf/beamer, typst, asciidoc) already guards this with $if(title)$; ipynb was missing it since the template was first added.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Snapshot predates removal of the empty "# " title header in ipynb output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering a document with no
titlemetadata toipynbemits an empty level-1 heading (#) as the first line of the notebook's first markdown cell.title-block.mdunconditionally emits# $title$regardless of whether a title is set. Every other title template (html, pdf/beamer, typst, asciidoc) already guards this with$if(title)$; ipynb was missing it since the template was added in 2022.Fixes #14693