Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions news/changelog-1.10.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ All changes included in 1.10:

- ([#14646](https://github.com/quarto-dev/quarto-cli/issues/14646)): Fix inline code formatting in a dashboard card title being extracted from its original position and appended elsewhere in the header instead of staying inline, the same issue previously fixed for math, emphasis and bold in [#10340](https://github.com/quarto-dev/quarto-cli/issues/10340).

### `ipynb`

- ([#14693](https://github.com/quarto-dev/quarto-cli/issues/14693)): Fix an empty level-1 heading (`# `) being emitted in the first markdown cell when rendering a document with no `title` to `ipynb`.

## Projects

### Manuscripts
Expand Down
2 changes: 1 addition & 1 deletion src/resources/formats/ipynb/templates/title-block.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
$-- Be very careful about whitespace in this document - line breaks are very meaningful
$-- and it is very easy to break the layout with poorly considered line breaks
# $title$
$if(title)$# $title$$endif$

$if(subtitle)$$subtitle$$endif$

Expand Down
1 change: 1 addition & 0 deletions tests/docs/doc-layout/title-block-no-title.qmd
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
hello world
2 changes: 0 additions & 2 deletions tests/docs/smoke-all/2024/01/19/8356.ipynb.snapshot
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"# \n",
"\n",
"## hello\n",
"\n",
"<table>\n",
Expand Down
10 changes: 10 additions & 0 deletions tests/smoke/render/render-title-block.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,13 @@ testRender(orcidIpynbAffilInput, "ipynb", true, [
matches: [/ORCID\s+profile\s+for\s+Norah\s+Jones/],
}),
]);

// ipynb: no title metadata should not produce an empty "# " header (#14693).
const noTitleInput = docs("doc-layout/title-block-no-title.qmd");
const noTitleIpynbOutput = outputForInput(noTitleInput, "ipynb");
testRender(noTitleInput, "ipynb", true, [
ensureIpynbCellMatches(noTitleIpynbOutput.outputPath, {
cellType: "markdown",
noMatches: [/^#\s*$/m],
}),
]);
Loading