Conversation
r3kste
left a comment
r3kste
left a comment
There was a problem hiding this comment.
I haven't run the code yet, but the implementation still needs a change.
Also, It would be easier for both us if you properly finish with one backend, before going for others.
| self._view_menu.add_command(label="XY Plane", command=lambda: set_view(90, -90)) | ||
| self._view_menu.add_command(label="XZ Plane", command=lambda: set_view(0, -90)) | ||
| self._view_menu.add_command(label="YZ Plane", command=lambda: set_view(0, 0)) |
There was a problem hiding this comment.
This is wrong. As we had discussed, backends should not have any reference to the view_init function.
Reasoning: As you can see, this needs defining the draw lambda and using them for all backends. But ideally this should be done in a backend independent way. If in the future, someone wants to add another action to the hamburger menu, all backends need a change. That is not acceptable.
Similar to how we defined context_menu to be used for any labels and actions, I think it would be better if a similar thing is implemented here.
| if self.get_navigate_mode() is not None: | ||
| # we don't want to rotate if we are zooming/panning | ||
| # from the toolbar | ||
| return | ||
|
|
|
Now that I notice, create a new branch and therefore a new PR on this fork. There is no need to use the old |
2 participants
PR summary
PR checklist