forked from Impaler343/matplotlib
-
Notifications
You must be signed in to change notification settings - Fork 1
Hamburger Menu #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7bb3303
prototype for right click context menu
AdwaithBatchu 5417d95
small fixes to gtk4 and some checks
AdwaithBatchu 69da89d
made suggested changes
AdwaithBatchu 7120a65
first prototype of hamburger menu
AdwaithBatchu 04bb7bb
small undos
AdwaithBatchu 257ffb7
small undos
AdwaithBatchu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1546,11 +1546,6 @@ def _on_move(self, event): | |
| if not self.button_pressed: | ||
| return | ||
|
|
||
| if self.get_navigate_mode() is not None: | ||
| # we don't want to rotate if we are zooming/panning | ||
| # from the toolbar | ||
| return | ||
|
|
||
| if self.M is None: | ||
| return | ||
|
|
||
|
|
@@ -1563,6 +1558,11 @@ def _on_move(self, event): | |
| w = self._pseudo_w | ||
| h = self._pseudo_h | ||
|
|
||
| if self.get_navigate_mode() is not None: | ||
| # we don't want to rotate if we are zooming/panning | ||
| # from the toolbar | ||
| return | ||
|
|
||
|
Comment on lines
+1561
to
+1565
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change seems unnecessary? |
||
| # Rotation | ||
| if self.button_pressed in self._rotate_btn: | ||
| # rotate viewing point | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. As we had discussed, backends should not have any reference to the view_init function.
Reasoning: As you can see, this needs defining the draw lambda and using them for all backends. But ideally this should be done in a backend independent way. If in the future, someone wants to add another action to the hamburger menu, all backends need a change. That is not acceptable.
Similar to how we defined
context_menuto be used for any labels and actions, I think it would be better if a similar thing is implemented here.