Support directional key commands - #227
Open
hontd wants to merge 7 commits into
Open
Conversation
rajdeep
requested changes
Oct 6, 2023
| var handled: Bool = false | ||
| presses.forEach { press in | ||
| guard let key = press.key else { return } | ||
| if key.charactersIgnoringModifiers == UIKeyCommand.inputUpArrow { |
Owner
There was a problem hiding this comment.
@hontd, if we keep a mapping of UIKeyCommand with EditorKey, we can get this if-else condition down to a single line without duplicating richTextViewDelegate?.richTextView(self, shouldHandle:. It would be easier to maintain then.
Owner
There was a problem hiding this comment.
Also, it would be great to add some tests here. Checkout RichTextViewContextTests for examples.
hontd
force-pushed
the
support-key-commands
branch
from
October 9, 2023 02:21
0a36d11 to
566fe54
Compare
rajdeep
reviewed
Oct 9, 2023
rajdeep
reviewed
Oct 9, 2023
hontd
force-pushed
the
support-key-commands
branch
from
October 9, 2023 03:35
566fe54 to
be3e8af
Compare
rajdeep
previously approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.