-
Notifications
You must be signed in to change notification settings - Fork 89
Support directional key commands #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hontd
wants to merge
7
commits into
rajdeep:main
Choose a base branch
from
hontd:support-key-commands
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
be3e8af
Support directional key commands
hthi-atlassian be3fede
Fix build failures
hthi-atlassian d2bdc47
Update workflow permissions
hthi-atlassian 0ae47c9
Disable Compile Test Results step for now
hthi-atlassian 51919c0
Updated workflow
rajdeep 322e0e2
Updated workflow file
rajdeep 838012d
Updated workflow file
rajdeep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // | ||
| // EditorKeyTests.swift | ||
| // ProtonTests | ||
| // | ||
| // Created by Hon Thi on 8/10/2023. | ||
| // Copyright © 2023 Rajdeep Kwatra. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
|
|
||
| import XCTest | ||
| @testable import Proton | ||
|
|
||
| final class EditorKeyTests: XCTestCase { | ||
| func test_ReturnsTab() { | ||
| XCTAssertEqual(EditorKey("\t"), EditorKey.tab) | ||
| } | ||
|
|
||
| func test_ReturnsEnter() { | ||
| XCTAssertEqual(EditorKey("\r"), EditorKey.enter) | ||
| XCTAssertEqual(EditorKey("\n"), EditorKey.enter) | ||
| } | ||
|
|
||
| func test_ReturnsUp() { | ||
| XCTAssertEqual(EditorKey(UIKeyCommand.inputUpArrow), EditorKey.up) | ||
| } | ||
|
|
||
| func test_ReturnsDown() { | ||
| XCTAssertEqual(EditorKey(UIKeyCommand.inputDownArrow), EditorKey.down) | ||
| } | ||
|
|
||
| func test_ReturnsLeft() { | ||
| XCTAssertEqual(EditorKey(UIKeyCommand.inputLeftArrow), EditorKey.left) | ||
| } | ||
|
|
||
| func test_ReturnsRight() { | ||
| XCTAssertEqual(EditorKey(UIKeyCommand.inputRightArrow), EditorKey.right) | ||
| } | ||
|
|
||
| func testReturnsNil() { | ||
| XCTAssertNil(EditorKey("any")) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // | ||
| // MockKeyboardPress.swift | ||
| // ProtonTests | ||
| // | ||
| // Created by Hon Thi on 6/10/2023. | ||
| // Copyright © 2023 Rajdeep Kwatra. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
|
|
||
| import UIKit | ||
|
|
||
| @available(iOS 13.4, *) | ||
| class MockUIPress: UIPress { | ||
| private let _characters: String | ||
| override var key: UIKey? { | ||
| MockUIKey(characters: _characters) | ||
| } | ||
|
|
||
| init(characters: String) { | ||
| self._characters = characters | ||
| } | ||
| } | ||
|
|
||
| @available(iOS 13.4, *) | ||
| class MockUIKey: UIKey { | ||
| private let _characters: String | ||
| override var charactersIgnoringModifiers: String { _characters } | ||
|
|
||
| init(characters: String) { | ||
| self._characters = characters | ||
| super.init() | ||
| } | ||
|
|
||
| required init?(coder: NSCoder) { | ||
| fatalError("init(coder:) has not been implemented") | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.