Simplify paid bounty records#573
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation and admin procedures now point paid-bounty readers to proof-backed activity feeds, ledger, and proof API endpoints instead of a maintained index. Tests and smoke checks were updated to require those endpoint phrases and the new “source of truth” wording while removing row-specific assertions. ChangesPaid Bounties Proof-Backed Documentation
Possibly related PRs
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
eliasx45
left a comment
eliasx45
left a comment
There was a problem hiding this comment.
Reviewed current head cbb210d398196880652d1266c1e60c93593fefb5 as a non-author.
No blocker found in my reviewed slice. The PR cleanly replaces the manually maintained paid-bounties table with a short guide pointing to the proof-backed activity feed, activity API, per-bounty accepted awards, ledger API, proof payloads, and optional discussion summaries. The surrounding README/docs page/admin-runbook/bounty-rules updates consistently move maintainers away from manual Markdown payment rows and toward authoritative ledger-backed records.
Validation performed:
git fetch origin main; diff confirmed focused to 7 docs/docs-test filesgit diff --check origin/main...HEADcleanpython scripts/docs_smoke.py-> docs smoke okpython -m pytest tests/test_docs_public_urls.py tests/test_api_mcp.py::test_docs_page_lists_live_ltclab_urls -q-> 24 passedpython scripts/check_agents.py-> okpython -m ruff check .-> passedpython -m ruff format --check .-> 79 files already formattedpython -m mypy app-> success- Public URL HEAD checks returned 200 for
/activity,/api/v1/activity,/api/v1/ledger, and GitHub Discussions #16 - Full suite:
python -m pytest -q-> 425 passed - Hosted Quality/readiness/docs/image check is passing
CodeRabbit was still marked pending/review-in-progress when I checked, so this approval is scoped to the diff, local validation, public URL verification, and hosted quality status above.
No private data, credentials, wallet material, signatures, production mutation, MRWK price/off-ramp, exchange/liquidity claims, bridge claims, or fabricated payout claims were used.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 348e5922-e43c-47ff-bf0a-0335b5d82fc7
📒 Files selected for processing (7)
README.mdapp/templates/docs.htmldocs/admin-runbook.mddocs/bounty-rules.mddocs/paid-bounties.mdscripts/docs_smoke.pytests/test_docs_public_urls.py
|
Reviewed current head Low-severity future-proofing note: the dated-row regression should be made year-agnostic before merge. Validation:
|
|
I rechecked the follow-up note from @yui-stingray after my earlier approval. I agree this is a useful future-proofing improvement: the current regression rejects the old I still do not see this as changing the core docs/readiness assessment I posted earlier, but I agree the stronger regex-style regression would be a good low-risk follow-up before merge if maintainers want the test to preserve the contract beyond 2026. |
jakerated-r
left a comment
jakerated-r
left a comment
There was a problem hiding this comment.
Reviewed current head cbb210d398196880652d1266c1e60c93593fefb5 as a non-author for the rolling PR-review bounty context in #567.
Verdict: no blocker found in my reviewed slice. The PR is focused to the paid-bounty documentation contract: it removes the manually maintained dated payment table, points readers to proof-backed activity/ledger/proof records, updates maintainer payout docs so new payments no longer require a Markdown row, and adds docs-smoke / public-doc tests for that contract.
Evidence checked:
- Inspected
docs/paid-bounties.md,docs/bounty-rules.md,docs/admin-runbook.md,README.md,app/templates/docs.html,scripts/docs_smoke.py, andtests/test_docs_public_urls.py. - Confirmed the changed docs point to the activity feed, activity API, ledger API, proof pages/API, per-bounty accepted-award pages, and optional GitHub Discussions summaries instead of dated payment-table rows.
- Confirmed
docs/paid-bounties.mdcontains the new source-of-truth wording and no| 2026-dated payment rows. - Public URL HEAD checks returned HTTP 200 for
https://mrwk.ltclab.site/activity,https://api.mrwk.ltclab.site/api/v1/activity,https://api.mrwk.ltclab.site/api/v1/ledger, andhttps://github.com/ramimbo/mergework/discussions/16. - GitHub reports the PR is open, non-draft, mergeable, and its hosted Quality/readiness/docs/image check plus CodeRabbit status are green.
Validation run locally on the PR diff:
uv run --extra dev python scripts/docs_smoke.py-> docs smoke okuv run --extra dev python -m pytest tests/test_docs_public_urls.py tests/test_api_mcp.py::test_docs_page_lists_live_ltclab_urls -q-> 24 passeduv run --extra dev python scripts/check_agents.py-> AGENTS.md okuv run --extra dev ruff check .-> passeduv run --extra dev ruff format --check .-> 79 files already formatteduv run --extra dev python -m mypy app-> successuv run --extra dev python -m pytest -q-> 425 passedgit diff --check-> clean
Scope note: I saw the existing future-proofing suggestion about making the dated-row regression year-agnostic. I agree it would be a useful hardening follow-up, but I did not find a merge-blocking issue in the current docs/readiness slice.
No private data, credentials, wallet material, signatures, production mutation, MRWK price/off-ramp, exchange/liquidity, bridge, or fabricated payout claims were used.
eliasx45
left a comment
eliasx45
left a comment
There was a problem hiding this comment.
Re-reviewed current head e3ae59d52e8d33b394d725d761b2bec90072ff1a after the follow-up commit.
No blocker found. The new commit resolves the year-specific regression gap I agreed with earlier: test_paid_bounties_points_to_authoritative_payment_records now imports re and rejects dated Markdown table rows with a year-agnostic multiline pattern (^\\|\\s*20\\d{2}-\\d{2}-\\d{2}\\b) instead of checking only | 2026-. That better preserves the PR's intended contract that docs/paid-bounties.md should route readers to proof-backed records rather than reintroducing manual dated payment rows in a future year.
Validation run locally on this head:
git diff --check origin/main...HEADrg -n "re\\.search|20\\\\d|paid-bounties|source of truth|not manually updated|activity" tests\\test_docs_public_urls.py docs\\paid-bounties.md scripts\\docs_smoke.py README.md docs\\admin-runbook.md docs\\bounty-rules.md app\\templates\\docs.html.\\.venv\\Scripts\\python.exe -m pytest tests\\test_docs_public_urls.py::test_paid_bounties_points_to_authoritative_payment_records tests\\test_docs_public_urls.py::test_readme_lists_live_ltclab_urls tests\\test_api_mcp.py::test_docs_page_lists_live_ltclab_urls -q-> 3 passed.\\.venv\\Scripts\\python.exe scripts\\docs_smoke.py-> docs smoke ok.\\.venv\\Scripts\\python.exe -m pytest tests\\test_docs_public_urls.py tests\\test_api_mcp.py::test_docs_page_lists_live_ltclab_urls -q-> 24 passed.\\.venv\\Scripts\\python.exe -m ruff check tests\\test_docs_public_urls.py scripts\\docs_smoke.py-> passed.\\.venv\\Scripts\\python.exe -m ruff format --check tests\\test_docs_public_urls.py scripts\\docs_smoke.py-> 2 files already formatted.\\.venv\\Scripts\\python.exe scripts\\check_agents.py-> AGENTS.md ok
Hosted Quality/readiness/docs/image is green for this head. CodeRabbit was still pending on the one-file follow-up when I checked, so this approval is scoped to the diff and local validation above.
|
Actionable comments posted: 0 |
jakerated-r
left a comment
jakerated-r
left a comment
There was a problem hiding this comment.
Reviewed current head e3ae59d52e8d33b394d725d761b2bec90072ff1a after the maintainer follow-up commit that changed the dated-row regression from a 2026-only string check to a year-agnostic Markdown-row pattern.
Verdict: no blocker found in this reviewed slice. The follow-up commit closes the future-year gap from the earlier discussion: tests/test_docs_public_urls.py now imports re and asserts that docs/paid-bounties.md does not contain dated payment table rows matching ^\|\s*20\d{2}-\d{2}-\d{2}\b, while the docs continue to route readers to proof-backed activity, ledger, bounty, and proof records instead of a manually maintained payment table.
Evidence checked:
- inspected
tests/test_docs_public_urls.py,docs/paid-bounties.md,scripts/docs_smoke.py,README.md,docs/admin-runbook.md,docs/bounty-rules.md, andapp/templates/docs.html; - confirmed
docs/paid-bounties.mdstill contains the source-of-truth language and the public activity/API/proof links; - confirmed
docs/admin-runbook.mdanddocs/bounty-rules.mdtell maintainers not to add manual payment rows and to use proof-backed records instead; - confirmed the PR diff remains focused to documentation, docs smoke checks, and public docs tests;
- public HEAD checks returned HTTP 200 for the activity page, activity API, ledger API, and GitHub Discussions #16.
Validation run locally:
uv run --extra dev python scripts/docs_smoke.py-> docs smoke okuv run --extra dev python -m pytest tests/test_docs_public_urls.py::test_paid_bounties_points_to_authoritative_payment_records tests/test_docs_public_urls.py::test_readme_lists_live_ltclab_urls tests/test_api_mcp.py::test_docs_page_lists_live_ltclab_urls -q-> 3 passeduv run --extra dev python -m pytest tests/test_docs_public_urls.py tests/test_api_mcp.py::test_docs_page_lists_live_ltclab_urls -q-> 24 passeduv run --extra dev python scripts/check_agents.py-> AGENTS.md okuv run --extra dev ruff check tests/test_docs_public_urls.py scripts/docs_smoke.py docs/paid-bounties.md README.md docs/admin-runbook.md docs/bounty-rules.md-> all checks passeduv run --extra dev ruff check .-> all checks passeduv run --extra dev ruff format --check .-> 79 files already formatteduv run --extra dev python -m mypy app-> successuv run --extra dev python -m pytest -q-> 425 passedgit diff --check origin/main...HEAD-> clean
This re-review is scoped to the current head after the new follow-up commit. No private data, credentials, wallet material, signatures, production mutation, MRWK price/off-ramp, exchange/liquidity, bridge, or fabricated payout claims were used.
4 participants
Summary
This is a maintainer docs PR. It is not a bounty claim. Review context: regular rolling PR review issue #567.
Checks
./.venv/bin/python scripts/docs_smoke.py./.venv/bin/python -m pytest tests/test_docs_public_urls.py tests/test_api_mcp.py::test_docs_page_lists_live_ltclab_urls./.venv/bin/python scripts/check_agents.py./.venv/bin/python -m ruff format --check ../.venv/bin/python -m ruff check ../.venv/bin/python -m mypy app./.venv/bin/python -m pytestSummary by CodeRabbit
Documentation
Tests
Chores