Skip to content

Add float benchmark, and some minor float fixes/cleanup#2864

Merged
kilograham merged 29 commits intodevelopfrom
float-benchmark
Mar 24, 2026
Merged

Add float benchmark, and some minor float fixes/cleanup#2864
kilograham merged 29 commits intodevelopfrom
float-benchmark

Conversation

@kilograham
Copy link
Copy Markdown
Contributor

No description provided.

@kilograham kilograham marked this pull request as draft March 11, 2026 18:36
@kilograham kilograham requested a review from lurch March 11, 2026 18:36
@kilograham
Copy link
Copy Markdown
Contributor Author

Actually converting to draft, as we should document the new defines (though they aren't really PICO_CONFIG as they are provided not options)

@kilograham kilograham added this to the 2.2.1 milestone Mar 11, 2026
@kilograham kilograham mentioned this pull request Mar 11, 2026
@kilograham kilograham marked this pull request as ready for review March 11, 2026 20:26
@kilograham kilograham marked this pull request as draft March 11, 2026 20:27
…cessor defines to identify which additional functions are present
@lurch
Copy link
Copy Markdown
Contributor

lurch commented Mar 12, 2026

Bazel is complaining that it hasn't been told about test/pico_float_test/double_benchmark.c and test/pico_float_test/float_benchmark.c yet 😉

check-configs is complaining because there's no #define PICO_DOUBLE_IN_RAM 0. In #2858 I added it to src/rp2_common/pico_double/double_v1_rom_shim_rp2040.S, copying what https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_float/float_v1_rom_shim_rp2040.S#L11 does.

@lurch
Copy link
Copy Markdown
Contributor

lurch commented Mar 17, 2026

check-configs is complaining because there's no #define PICO_DOUBLE_IN_RAM 0. In #2858 I added it to src/rp2_common/pico_double/double_v1_rom_shim_rp2040.S, copying what https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_float/float_v1_rom_shim_rp2040.S#L11 does.

This is still the case 😉

Co-authored-by: Andrew Scheller <lurch@durge.org>
kilograham and others added 2 commits March 19, 2026 13:56
Co-authored-by: Graham Sanderson <graham.sanderson@gmail.com>
Co-authored-by: Andrew Scheller <lurch@durge.org>
kilograham and others added 2 commits March 19, 2026 14:03
Co-authored-by: Graham Sanderson <graham.sanderson@gmail.com>
@lurch
Copy link
Copy Markdown
Contributor

lurch commented Mar 20, 2026

Yikes, CI builds are all failing with

/opt/actions-runner/_work/pico-sdk/pico-sdk/src/rp2_common/pico_double/include/pico/double.h:7: error: unterminated #ifndef
    7 | #ifndef _PICO_DOUBLE_H

@lurch
Copy link
Copy Markdown
Contributor

lurch commented Mar 20, 2026

  • test/pico_float_test/pico_double_test.c is testing sqrt_fast - should test/pico_float_test/pico_float_test.c be testing sqrtf_fast?
  • Should test/pico_float_test/pico_double_test.c also be testing ddiv_fast ?
  • Should test/pico_float_test/pico_float_test.c also be testing fdiv_fast ?

P.S. furious_fast(7) 🏎️ 😆

kilograham and others added 6 commits March 24, 2026 10:59
Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>
Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>
Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>
@kilograham
Copy link
Copy Markdown
Contributor Author

  • test/pico_float_test/pico_double_test.c is testing sqrt_fast - should test/pico_float_test/pico_float_test.c be testing sqrtf_fast?

sure

* Should `test/pico_float_test/pico_double_test.c` also be testing `ddiv_fast` ?

already was

* Should `test/pico_float_test/pico_float_test.c` also be testing `fdiv_fast` ?

sure

P.S. furious_fast(7) 🏎️ 😆

@kilograham kilograham merged commit e7d150f into develop Mar 24, 2026
11 checks passed
@kilograham kilograham deleted the float-benchmark branch March 24, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants