RDKEMW-19283: Fix AUTO mode runtime state not updating when persist=false#255
Merged
apatel859 merged 6 commits intoJun 3, 2026
Merged
Conversation
…alse Move runtime AUTO state update outside persistence conditional block. Ensures immediate readback when setSoundMode(AUTO, persist=false).
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bug where setStereoAuto(AUTO, persist=false) would not update the in-process runtime AUTO flags (_srv_Audio*Auto), causing getStereoAuto()/getStereoMode() to return stale values until restart. The handler is refactored so the per-port runtime state is always updated, while HostPersistence writes remain conditional on param->toPersist.
Changes:
- Refactor
_dsSetStereoAutoto resolve the runtime state pointer per port via a switch, update it unconditionally, and gate persistence ontoPersist. - Move HAL
dsSetStereoAutoinvocation for HDMI_ARC/SPDIF ahead of the runtime/persistence update, returning early (with an attempted rollback) on HAL failure. - Add null/invalid-handle guards and propagate the result back via a
resultvariable rather than hard-codingIARM_RESULT_SUCCESS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| case dsAUDIOPORT_TYPE_SPEAKER: | ||
| device::HostPersistence::getInstance().persistHostProperty("SPEAKER0.AudioMode.AUTO", param->autoMode ? "TRUE" : "FALSE"); | ||
| break; | ||
| default: |
Contributor
Author
There was a problem hiding this comment.
Resolved in new commit.
RDKEMW-16730 : Evaluation on finding invalid markers in entservices r…
apatel859
previously approved these changes
Jun 3, 2026
apatel859
approved these changes
Jun 3, 2026
arun-madhavan-013
deleted the
feature/RDKEMW-19283-map-dsSetStereoAuto-properly
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move runtime AUTO state update outside persistence conditional block. Ensures immediate readback when setSoundMode(AUTO, persist=false).