Skip to content

RDKEMW-19283: Fix AUTO mode runtime state not updating when persist=false #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apatel859 merged 6 commits into from
Jun 3, 2026
+51 −32
Merged

RDKEMW-19283: Fix AUTO mode runtime state not updating when persist=false #255

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
67d8402
RDKEMW-19283: Fix AUTO mode runtime state not updating when persist=f…
arun-madhavan-013 May 29, 2026
1264768
Remove unused variable and fix param validation logic
arun-madhavan-013 Jun 1, 2026
06af323
Merge branch 'develop' into feature/RDKEMW-19283-map-dsSetStereoAuto-…
arun-madhavan-013 Jun 1, 2026
b4dbebe
Merge pull request #256 from rdkcentral/develop
arun-madhavan-013 Jun 2, 2026
848c3b2
Merge branch 'develop' into feature/RDKEMW-19283-map-dsSetStereoAuto-…
apatel859 Jun 3, 2026
e8e42f3
RDKEMW-19283: address coverity scope - remove unused var and unreacha…
arun-madhavan-013 Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 51 additions & 32 deletions rpc/srv/dsAudio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2836,42 +2836,40 @@ IARM_Result_t _dsGetStereoAuto(void *arg)
IARM_Result_t _dsSetStereoAuto(void *arg)
{
_DEBUG_ENTER();
IARM_BUS_Lock(lock);
if (!arg) {
return IARM_RESULT_INVALID_PARAM;
}

IARM_Result_t result = IARM_RESULT_INVALID_STATE;
dsAudioSetStereoAutoParam_t *param = (dsAudioSetStereoAutoParam_t *)arg;

dsAudioPortType_t _APortType = _GetAudioPortType(param->handle);

if (param->toPersist) {
switch(_APortType) {
case dsAUDIOPORT_TYPE_HDMI:
device::HostPersistence::getInstance().persistHostProperty("HDMI0.AudioMode.AUTO", param->autoMode ? "TRUE" : "FALSE");
_srv_AudioHDMIAuto = param->autoMode;
break;

case dsAUDIOPORT_TYPE_HDMI_ARC:
device::HostPersistence::getInstance().persistHostProperty("HDMI_ARC0.AudioMode.AUTO", param->autoMode ? "TRUE" : "FALSE");
_srv_AudioHDMIARCAuto = param->autoMode;
break;

case dsAUDIOPORT_TYPE_SPDIF:
device::HostPersistence::getInstance().persistHostProperty("SPDIF0.AudioMode.AUTO", param->autoMode ? "TRUE" : "FALSE");
_srv_AudioSPDIFAuto = param->autoMode;
break;
IARM_BUS_Lock(lock);

dsAudioPortType_t _APortType = _GetAudioPortType(param->handle);
int *runtimeAutoPtr = NULL;

switch(_APortType) {
case dsAUDIOPORT_TYPE_HDMI:
runtimeAutoPtr = &_srv_AudioHDMIAuto;
break;
case dsAUDIOPORT_TYPE_HDMI_ARC:
runtimeAutoPtr = &_srv_AudioHDMIARCAuto;
break;
case dsAUDIOPORT_TYPE_SPDIF:
runtimeAutoPtr = &_srv_AudioSPDIFAuto;
break;
case dsAUDIOPORT_TYPE_SPEAKER:
device::HostPersistence::getInstance().persistHostProperty("SPEAKER0.AudioMode.AUTO", param->autoMode ? "TRUE" : "FALSE");
_srv_AudioSPEAKERAuto = param->autoMode;
break;
default:
break;
}
runtimeAutoPtr = &_srv_AudioSPEAKERAuto;
break;
default:
IARM_BUS_Unlock(lock);
return IARM_RESULT_INVALID_PARAM;
Comment thread
arun-madhavan-013 marked this conversation as resolved.
}

if ((_APortType == dsAUDIOPORT_TYPE_HDMI_ARC) || (_APortType == dsAUDIOPORT_TYPE_SPDIF)) {
typedef dsError_t (*dsSetStereoAuto_t)(intptr_t handle, int autoMode);
static dsSetStereoAuto_t func = 0;
bool halUpdateSuccess = false;

if (func == 0) {
void *dllib = dlopen(RDK_DSHAL_NAME, RTLD_LAZY);
if (dllib) {
Expand All @@ -2889,12 +2887,33 @@ IARM_Result_t _dsSetStereoAuto(void *arg)
}
}

if (func != 0)
{
if (func(param->handle, param->autoMode) == dsERR_NONE)
{
result = IARM_RESULT_SUCCESS;
}
if (func != 0) {
halUpdateSuccess = (func(param->handle, param->autoMode) == dsERR_NONE);
}

if (!halUpdateSuccess) {
IARM_BUS_Unlock(lock);
return IARM_RESULT_INVALID_STATE;
}
Comment thread
arun-madhavan-013 marked this conversation as resolved.
Comment thread
arun-madhavan-013 marked this conversation as resolved.
}

/* Update runtime auto-state for immediate readback behavior. */
*runtimeAutoPtr = param->autoMode ? 1 : 0;

if (param->toPersist) {
switch(_APortType) {
case dsAUDIOPORT_TYPE_HDMI:
device::HostPersistence::getInstance().persistHostProperty("HDMI0.AudioMode.AUTO", param->autoMode ? "TRUE" : "FALSE");
break;
case dsAUDIOPORT_TYPE_HDMI_ARC:
device::HostPersistence::getInstance().persistHostProperty("HDMI_ARC0.AudioMode.AUTO", param->autoMode ? "TRUE" : "FALSE");
break;
case dsAUDIOPORT_TYPE_SPDIF:
device::HostPersistence::getInstance().persistHostProperty("SPDIF0.AudioMode.AUTO", param->autoMode ? "TRUE" : "FALSE");
break;
case dsAUDIOPORT_TYPE_SPEAKER:
device::HostPersistence::getInstance().persistHostProperty("SPEAKER0.AudioMode.AUTO", param->autoMode ? "TRUE" : "FALSE");
break;
}
}

Expand Down
Loading