feat: actions.intent() and related eventing by brendanobra · Pull Request #63 · rdkcentral/firebolt-cpp-client

brendanobra · 2026-05-26T21:58:00Z

Summary

This PR adds Actions API support in the Firebolt C++ client (including intent + onIntent event wiring) and improves local developer workflows for tests, tunnel setup, and linting.

What Changed

Added Actions module surface and implementation for intent flow.
Added onIntent subscription support with unsubscribe and unsubscribeAll.
Integrated Actions cleanup into Firebolt lifecycle teardown.
Added JSON type support for Actions payload handling.
Added unit tests for Actions intent and event subscription behavior.
Split local test execution into dedicated scripts:
- run-unit-tests.sh
- run-component-tests.sh
- run-all-test.sh now delegates to those scripts.
Added secure device tunnel helper script with required environment variables.
Added lint.sh helper for local static analysis.
Added optional auto-fix mode for clang-tidy via --fix.
Updated README docs for test runners, tunnel usage, and lint usage.

Validation

Shell script syntax checks passed.
Unit smoke run passed via aggregate runner:
- ./run-all-test.sh --unit-only
Unit tests: 96 passed, 0 failed.
lint.sh help and argument parsing validated.
lint.sh now shows per-file progress during clang-tidy runs.

Notes

Lint is report-only by default.
Auto-fix is opt-in with --fix and applies only to clang-tidy.
Default clang-tidy scope excludes demo app sources to reduce noisy compile diagnostics.
Demo app sources can still be included with:
- --tidy-path test/api_test_app

Risk

Low to moderate.
Main risk areas are subscription lifecycle cleanup and script workflow behavior.
Mitigated by new unit coverage and smoke validation.

Reviewer Focus

Actions event subscription and lifecycle cleanup logic.
run-all-test.sh argument forwarding and delegation behavior.
Lint helper defaults vs team workflow expectations (report-only by default, fix opt-in).

Copilot

Pull request overview

This PR adds initial Firebolt Actions support to the C++ client (including intent() and onIntent subscription wiring) and updates local developer tooling for running tests, tunneling to a device endpoint, and linting.

Changes:

Adds a new Firebolt::Actions public interface, implementation, and accessor integration (including unsubscribeAll() lifecycle handling).
Adds unit tests for Actions::intent() and Actions::subscribeOnIntent().
Improves local workflows with new unit/component test runner scripts, an SSH device tunnel helper, and a lint.sh helper; also tweaks component-test endpoint selection and SYSROOT handling in build.sh.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
test/unit/actionsTest.cpp	Adds unit tests for `intent()` and `onIntent` subscription.
test/ComponentTestsMain.cpp	Uses `FIREBOLT_ENDPOINT` env var with a new default endpoint for component tests.
test/CMakeLists.txt	Points unit tests at the OpenRPC schema via an absolute source-tree path define.
src/json_types/actions.h	Introduces generated JSON-type header placeholder for Actions.
src/firebolt.cpp	Wires Actions into the accessor and `unsubscribeAll()` flow.
src/actions_impl.h	Declares the generated `ActionsImpl` implementation.
src/actions_impl.cpp	Implements `intent()` and `subscribeOnIntent()` using helper + subscription manager.
setup-device-tunnel.sh	Adds SSH local-forward tunnel helper using required env vars.
run-unit-tests.sh	Adds a focused unit-test build/run helper script.
run-component-tests.sh	Adds a focused component-test build/run helper script.
run-all-test.sh	Refactors aggregate test runner to delegate to unit/component scripts.
README.md	Documents the new test runners and lint helper usage.
lint.sh	Adds local clang-tidy/cppcheck runner with optional clang-tidy fix mode.
include/firebolt/firebolt.h	Exposes the Actions interface on `IFireboltAccessor`.
include/firebolt/actions.h	Adds the public Actions API interface definition.
build.sh	Makes `SYSROOT_PATH` optional and updates how it’s passed to CMake.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-advanced-security · 2026-05-27T16:12:44Z

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 8 comments.

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 9 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.

rdkcmf-jenkins · 2026-05-27T22:44:03Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/firebolt-cpp-client/63/rdkcentral/firebolt-native-transport
Commit: 5423100

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

rdkcmf-jenkins · 2026-05-27T22:51:53Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/firebolt-cpp-client/63/rdkcentral/firebolt-native-transport
Commit: 2a0b0b9

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.

rdkcmf-jenkins · 2026-05-28T10:05:23Z

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

Upvote reason: ok
Commit: 2a0b0b9
'

tomasz-blasz · 2026-06-04T01:58:14Z

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

feat: actions.intent() and related eventing

63604b0

Copilot AI review requested due to automatic review settings May 26, 2026 21:58

Copilot started reviewing on behalf of brendanobra May 26, 2026 21:58 View session

brendanobra requested a review from satlead May 26, 2026 22:00

Copilot AI reviewed May 26, 2026

View reviewed changes

Comment thread src/actions_impl.cpp Outdated

Comment thread test/unit/actionsTest.cpp Outdated

Comment thread build.sh

Comment thread include/firebolt/actions.h Outdated

Comment thread src/json_types/actions.h Outdated

Comment thread src/firebolt.cpp Outdated

fix: copilot feedback on bad accessor

d1c7f4c

chore(actions): regenerate json_types with JsonData namespace

87dc59c

Copilot AI review requested due to automatic review settings May 27, 2026 20:35

Copilot started reviewing on behalf of brendanobra May 27, 2026 20:35 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

bobra200 added 2 commits May 27, 2026 13:47

fix(scripts): validate option args and guard install without sysroot

a201bef

feat(actions): rename start API to intent

2a7e03c

Copilot AI review requested due to automatic review settings May 27, 2026 21:15

Copilot started reviewing on behalf of brendanobra May 27, 2026 21:16 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

bobra200 and others added 2 commits May 27, 2026 14:38

fix(actions): address review feedback on headers and scripts

e6c37d3

Potential fix for pull request finding

da592f3

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 27, 2026 21:48

Copilot started reviewing on behalf of brendanobra May 27, 2026 21:48 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

Comment thread include/firebolt/firebolt.h Outdated

Comment thread include/firebolt/actions.h

Comment thread src/actions_impl.h

Potential fix for pull request finding

d744c05

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 27, 2026 21:51

Copilot started reviewing on behalf of brendanobra May 27, 2026 21:51 View session

fix(review): harden thread resolver and make ActionsImpl non-copyable

118d76a

Copilot AI reviewed May 27, 2026

View reviewed changes

Comment thread include/firebolt/actions.h

Comment thread src/actions_impl.h

bobra200 added 2 commits May 27, 2026 14:56

fix(review): address remaining ABI and include comments

8a5f934

test(actions): add component coverage for intent and onIntent

9d86e6c

Copilot AI review requested due to automatic review settings May 27, 2026 21:57

Copilot started reviewing on behalf of brendanobra May 27, 2026 21:57 View session

Merge branch 'develop' into feat/actions-api

6648db2

Copilot AI reviewed May 27, 2026

View reviewed changes

Comment thread test/ComponentTestsMain.cpp Outdated

Comment thread resolve-review-threads.sh Outdated

Comment thread resolve-review-threads.sh Outdated

fix(review): address latest CI and script feedback

e3506a8

brendanobra requested a review from Copilot May 27, 2026 22:10

Copilot started reviewing on behalf of brendanobra May 27, 2026 22:10 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

bobra200 added 2 commits May 27, 2026 15:26

chore: remove review-thread helper script from PR

d416d8a

fix(lint): add clang-format check/fix and apply formatting

5423100

Copilot AI review requested due to automatic review settings May 27, 2026 22:41

Copilot started reviewing on behalf of brendanobra May 27, 2026 22:41 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

Comment thread lint.sh

Comment thread test/component/actionsGeneratedTest.cpp

fix(review): tighten test safety and lint mode semantics

2a0b0b9

brendanobra requested a review from Copilot May 27, 2026 22:53

Copilot started reviewing on behalf of brendanobra May 27, 2026 22:53 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

satlead approved these changes May 29, 2026

View reviewed changes

brendanobra merged commit 1192f3c into develop May 29, 2026
8 checks passed

brendanobra deleted the feat/actions-api branch May 29, 2026 20:19

github-actions Bot locked and limited conversation to collaborators May 29, 2026

tomasz-blasz added the released label Jun 4, 2026

Conversation

brendanobra commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

Validation

Notes

Risk

Reviewer Focus

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-advanced-security AI commented May 27, 2026

What Enabling Code Scanning Means:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brendanobra commented May 26, 2026 •

edited

Loading