-
Notifications
You must be signed in to change notification settings - Fork 1
feat: actions.intent() and related eventing #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
63604b0
feat: actions.intent() and related eventing
d1c7f4c
fix: copilot feedback on bad accessor
87dc59c
chore(actions): regenerate json_types with JsonData namespace
a201bef
fix(scripts): validate option args and guard install without sysroot
2a7e03c
feat(actions): rename start API to intent
e6c37d3
fix(actions): address review feedback on headers and scripts
da592f3
Potential fix for pull request finding
brendanobra d744c05
Potential fix for pull request finding
brendanobra 118d76a
fix(review): harden thread resolver and make ActionsImpl non-copyable
8a5f934
fix(review): address remaining ABI and include comments
9d86e6c
test(actions): add component coverage for intent and onIntent
6648db2
Merge branch 'develop' into feat/actions-api
brendanobra e3506a8
fix(review): address latest CI and script feedback
d416d8a
chore: remove review-thread helper script from PR
5423100
fix(lint): add clang-format check/fix and apply formatting
2a0b0b9
fix(review): tighten test safety and lint mode semantics
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /** | ||
| * Copyright 2026 Comcast Cable Communications Management, LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
| // | ||
| // ============================================================================ | ||
| // AUTO-GENERATED by fb-gen — DO NOT EDIT | ||
| // ============================================================================ | ||
|
brendanobra marked this conversation as resolved.
|
||
| #ifndef FIREBOLT_ACTIONS_H | ||
| #define FIREBOLT_ACTIONS_H | ||
|
|
||
| #include <firebolt/types.h> | ||
| #include <functional> | ||
| #include <optional> | ||
| #include <string> | ||
| #include <unordered_map> | ||
| #include <utility> | ||
| #include <vector> | ||
|
|
||
| namespace Firebolt::Actions | ||
| { | ||
|
|
||
| class IActions | ||
| { | ||
| public: | ||
| virtual ~IActions() = default; | ||
|
|
||
| virtual Result<void> intent(const std::string& intent) const = 0; | ||
|
|
||
| virtual Result<SubscriptionId> subscribeOnIntent(std::function<void(const std::string&)>&& notification) = 0; | ||
| virtual Result<SubscriptionId> subscribeOnIntentChanged(std::function<void(const std::string&)>&& notification) | ||
| { | ||
| return subscribeOnIntent(std::move(notification)); | ||
|
brendanobra marked this conversation as resolved.
brendanobra marked this conversation as resolved.
|
||
| } | ||
|
|
||
| virtual Result<void> unsubscribe(SubscriptionId id) = 0; | ||
| virtual void unsubscribeAll() = 0; | ||
|
|
||
| }; // class IActions | ||
|
|
||
| } // namespace Firebolt::Actions | ||
|
|
||
| #endif // FIREBOLT_ACTIONS_H | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.