Skip to content

fix: improve measurerow a11y expirerence#1346

Closed
afc163 wants to merge 5 commits into
antd-5.xfrom
fix/measurerow-tab-index
Closed

fix: improve measurerow a11y expirerence#1346
afc163 wants to merge 5 commits into
antd-5.xfrom
fix/measurerow-tab-index

Conversation

@afc163
Copy link
Copy Markdown
Member

@afc163 afc163 commented Sep 6, 2025

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
table Ready Ready Preview Comment Sep 6, 2025 4:28pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 6, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/measurerow-tab-index

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a targeted accessibility enhancement within a specific component. The change ensures that a visually and semantically hidden table row is also explicitly removed from the keyboard tab order, preventing unintended focus and improving the overall user experience for assistive technology users.

Highlights

  • Accessibility Improvement: The pull request enhances the accessibility experience for the MeasureRow component by ensuring that the hidden table row is not focusable via keyboard navigation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the accessibility of the MeasureRow component by adding tabIndex={-1} to the <tr> element. This change addresses a browser-specific bug where a visually hidden element could still receive focus, causing a confusing experience for screen reader users. The fix is appropriate and well-implemented. The accompanying formatting changes also improve code readability.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.76%. Comparing base (835364f) to head (e30241e).
⚠️ Report is 1 commits behind head on antd-5.x.

Additional details and impacted files
@@            Coverage Diff            @@
##           antd-5.x    #1346   +/-   ##
=========================================
  Coverage     97.75%   97.76%           
=========================================
  Files            77       77           
  Lines          7678     7683    +5     
  Branches       1165     1165           
=========================================
+ Hits           7506     7511    +5     
  Misses          166      166           
  Partials          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant