Skip to content

fix: improve measurerow a11y expirerence #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
afc163 wants to merge 5 commits into from
Closed

fix: improve measurerow a11y expirerence #1346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c20ecc
fix: improve measurerow ally expirerence
afc163 Sep 6, 2025
e688eba
test: update snapshot
afc163 Sep 6, 2025
6794e5d
Merge branch 'antd-5.x' into fix/measurerow-tab-index
afc163 Sep 6, 2025
8d3d8f1
Merge branch 'antd-5.x' into fix/measurerow-tab-index
afc163 Sep 6, 2025
e30241e
Update MeasureRow.tsx
afc163 Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Body/MeasureRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ export default function MeasureRow({
const { measureRowRender } = useContext(TableContext, ['measureRowRender']);

const measureRow = (
<tr aria-hidden="true" className={`${prefixCls}-measure-row`} style={{ height: 0 }} ref={ref}>
<tr
aria-hidden="true"
tabIndex={-1}
className={`${prefixCls}-measure-row`}
style={{ height: 0 }}
ref={ref}
>
<ResizeObserver.Collection
onBatchResize={infoList => {
if (isVisible(ref.current)) {
Expand Down
5 changes: 5 additions & 0 deletions tests/__snapshots__/ExpandRow.spec.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ LoadedCheerio {
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down Expand Up @@ -374,6 +375,7 @@ LoadedCheerio {
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down Expand Up @@ -677,6 +679,7 @@ LoadedCheerio {
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down Expand Up @@ -1231,6 +1234,7 @@ LoadedCheerio {
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down Expand Up @@ -1419,6 +1423,7 @@ LoadedCheerio {
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down
8 changes: 8 additions & 0 deletions tests/__snapshots__/FixedColumn.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ LoadedCheerio {
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down Expand Up @@ -948,6 +949,7 @@ LoadedCheerio {
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down Expand Up @@ -1767,6 +1769,7 @@ LoadedCheerio {
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down Expand Up @@ -2110,6 +2113,7 @@ LoadedCheerio {
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down Expand Up @@ -2962,6 +2966,7 @@ LoadedCheerio {
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down Expand Up @@ -3207,6 +3212,7 @@ exports[`Table.FixedColumn > shadow should be shown when there are columns where
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down Expand Up @@ -5757,6 +5763,7 @@ exports[`Table.FixedColumn > shadow should display correctly 1`] = `
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down Expand Up @@ -11749,6 +11756,7 @@ exports[`Table.FixedColumn > shadow should display correctly 2`] = `
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down
1 change: 1 addition & 0 deletions tests/__snapshots__/Table.spec.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ LoadedCheerio {
aria-hidden="true"
class="rc-table-measure-row"
style="height: 0px;"
tabindex="-1"
>
<td
style="padding-top: 0px; padding-bottom: 0px; border-top: 0px; border-bottom: 0px; height: 0px;"
Expand Down