Remove redundant operator!= definitions in react-native-github#1892
Closed
NickGerleman wants to merge 1 commit into
Closed
Remove redundant operator!= definitions in react-native-github#1892NickGerleman wants to merge 1 commit into
NickGerleman wants to merge 1 commit into
Conversation
Summary: C++20 automatically generates `operator!=` from `operator==`, making explicit `operator!=` definitions redundant. This removes all such redundant definitions across the React Native C++ codebase, including: - Simple negation patterns (`return !(*this == rhs)`) - Explicit `= default` declarations that duplicate the compiler-generated behavior - Both member and free-function forms Files in jsi/ were excluded as they are mirrored to a project that may not support C++20. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D94370249
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94370249. |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 25, 2026
Summary: X-link: react/yoga#1892 C++20 automatically generates `operator!=` from `operator==`, making explicit `operator!=` definitions redundant. This removes all such redundant definitions across the React Native C++ codebase, including: - Simple negation patterns (`return !(*this == rhs)`) - Explicit `= default` declarations that duplicate the compiler-generated behavior - Both member and free-function forms Files in jsi/ were excluded as they are mirrored to a project that may not support C++20. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D94370249
meta-codesync Bot
pushed a commit
to react/react-native
that referenced
this pull request
Feb 25, 2026
Summary: Pull Request resolved: #55746 X-link: react/yoga#1892 C++20 automatically generates `operator!=` from `operator==`, making explicit `operator!=` definitions redundant. This removes all such redundant definitions across the React Native C++ codebase, including: - Simple negation patterns (`return !(*this == rhs)`) - Explicit `= default` declarations that duplicate the compiler-generated behavior - Both member and free-function forms Files in jsi/ were excluded as they are mirrored to a project that may not support C++20. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D94370249 fbshipit-source-id: f1c73d38a61ff9e780bd16a797e6ce71b1900d00
|
This pull request has been merged in 369f715. |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
…#55746) Summary: Pull Request resolved: react#55746 X-link: react/yoga#1892 C++20 automatically generates `operator!=` from `operator==`, making explicit `operator!=` definitions redundant. This removes all such redundant definitions across the React Native C++ codebase, including: - Simple negation patterns (`return !(*this == rhs)`) - Explicit `= default` declarations that duplicate the compiler-generated behavior - Both member and free-function forms Files in jsi/ were excluded as they are mirrored to a project that may not support C++20. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D94370249 fbshipit-source-id: f1c73d38a61ff9e780bd16a797e6ce71b1900d00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
C++20 automatically generates
operator!=fromoperator==, making explicitoperator!=definitions redundant. This removes all such redundant definitions across the React Native C++ codebase, including:return !(*this == rhs))= defaultdeclarations that duplicate the compiler-generated behaviorFiles in jsi/ were excluded as they are mirrored to a project that may not support C++20.
Changelog: [Internal]
Reviewed By: sammy-SC
Differential Revision: D94370249