Skip to content

Remove redundant operator!= definitions in react-native-github #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NickGerleman wants to merge 1 commit into from
Closed

Remove redundant operator!= definitions in react-native-github #1892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions yoga/YGValue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,6 @@ inline bool operator==(const YGValue& lhs, const YGValue& rhs) {
}
}

inline bool operator!=(const YGValue& lhs, const YGValue& rhs) {
return !(lhs == rhs);
}

inline YGValue operator-(const YGValue& value) {
return {-value.value, value.unit};
}
Expand Down
1 change: 0 additions & 1 deletion yoga/enums/YogaEnums.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ auto ordinals() {
}

bool operator==(const Iterator& other) const = default;
bool operator!=(const Iterator& other) const = default;
};

struct Range {
Expand Down
3 changes: 0 additions & 3 deletions yoga/node/LayoutResults.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,6 @@ struct LayoutResults {
}

bool operator==(LayoutResults layout) const;
bool operator!=(LayoutResults layout) const {
return !(*this == layout);
}

private:
Direction direction_ : bitCount<Direction>() = Direction::Inherit;
Expand Down
9 changes: 0 additions & 9 deletions yoga/numeric/FloatOptional.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,23 +44,14 @@ constexpr bool operator==(FloatOptional lhs, FloatOptional rhs) {
return lhs.unwrap() == rhs.unwrap() ||
(lhs.isUndefined() && rhs.isUndefined());
}
constexpr bool operator!=(FloatOptional lhs, FloatOptional rhs) {
return !(lhs == rhs);
}

constexpr bool operator==(FloatOptional lhs, float rhs) {
return lhs == FloatOptional{rhs};
}
constexpr bool operator!=(FloatOptional lhs, float rhs) {
return !(lhs == rhs);
}

constexpr bool operator==(float lhs, FloatOptional rhs) {
return rhs == lhs;
}
constexpr bool operator!=(float lhs, FloatOptional rhs) {
return !(lhs == rhs);
}

constexpr FloatOptional operator+(FloatOptional lhs, FloatOptional rhs) {
return FloatOptional{lhs.unwrap() + rhs.unwrap()};
Expand Down
4 changes: 0 additions & 4 deletions yoga/style/Style.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,10 +548,6 @@ class YG_EXPORT Style {
numbersEqual(aspectRatio_, pool_, other.aspectRatio_, other.pool_);
}

bool operator!=(const Style& other) const {
return !(*this == other);
}

private:
using Dimensions = std::array<StyleValueHandle, ordinalCount<Dimension>()>;
using Edges = std::array<StyleValueHandle, ordinalCount<Edge>()>;
Expand Down
Loading