Remove commented-out duplicate code in YGMeasureTest#1927
Closed
J8118 wants to merge 3 commits into
Closed
Conversation
Remove three commented-out YGNodeSetMeasureFunc calls that duplicate the active calls on adjacent lines. All three date from 2017 (fbd332d) and were left behind when the active lines were later updated.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
facebook-github-tools
Bot
added
the
Shared with Meta
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D100144096. |
|
@fabriziocucci merged this pull request in cd0c6fd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove three commented-out
YGNodeSetMeasureFunccalls intests/YGMeasureTest.cppthat are exact duplicates of the active calls on adjacent lines.All three were introduced in commit
fbd332d(2017-12-19) and left behind when the active lines were later updated by other authors. Each commented-out line sits directly next to its active duplicate:Test plan
YGNodeSetMeasureFunccalls remain unchanged