Skip to content

Remove commented-out duplicate code in YGMeasureTest #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
J8118 wants to merge 3 commits into from
+0 −3
Closed

Remove commented-out duplicate code in YGMeasureTest #1927

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65c793e
Remove commented-out duplicate code in YGMeasureTest
J8118 Apr 9, 2026
c690e43
Merge branch 'main' into fix/remove-dead-code-tests
J8118 Apr 9, 2026
ec616a2
Merge branch 'main' into fix/remove-dead-code-tests
J8118 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tests/YGMeasureTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ TEST(YogaTest, measure_not_enough_size_should_wrap) {

YGNodeRef root_child0 = YGNodeNew();
YGNodeStyleSetAlignSelf(root_child0, YGAlignFlexStart);
// YGNodeSetMeasureFunc(root_child0, _simulate_wrapping_text);
YGNodeSetMeasureFunc(root_child0, _simulate_wrapping_text);
YGNodeInsertChild(root, root_child0, 0);

Expand Down Expand Up @@ -334,7 +333,6 @@ TEST(YogaTest, measure_flex_direction_column_and_padding) {

YGNodeRef root_child0 = YGNodeNewWithConfig(config);
YGNodeSetMeasureFunc(root_child0, _simulate_wrapping_text);
// YGNodeSetMeasureFunc(root_child0, _simulate_wrapping_text);
YGNodeInsertChild(root, root_child0, 0);

YGNodeRef root_child1 = YGNodeNewWithConfig(config);
Expand Down Expand Up @@ -373,7 +371,6 @@ TEST(YogaTest, measure_flex_direction_row_no_padding) {
YGNodeStyleSetHeight(root, 50);

YGNodeRef root_child0 = YGNodeNewWithConfig(config);
// YGNodeSetMeasureFunc(root_child0, _simulate_wrapping_text);
YGNodeSetMeasureFunc(root_child0, _simulate_wrapping_text);
YGNodeInsertChild(root, root_child0, 0);

Expand Down
Loading