fix(#3577): remove a11y violation filter and fix accessibility issues#3582
fix(#3577): remove a11y violation filter and fix accessibility issues#3582fullsend-ai-coder[bot] wants to merge 2 commits into
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3582 +/- ##
=======================================
Coverage 54.23% 54.23%
=======================================
Files 2307 2307
Lines 88341 88341
Branches 24652 24638 -14
=======================================
Hits 47908 47908
- Misses 40211 40212 +1
+ Partials 222 221 -1
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
/fs-fix There are some a11y issue now in the code base. Here are some errors from playwright. Try to fix these issues without changing everything. Keep focused on the specific components. |
|
🤖 Finished Fix · ✅ Success · Started 6:38 PM UTC · Completed 6:54 PM UTC |
Remove the accessibility violation filter from e2e-tests/utils/accessibility.ts that was suppressing four axe-core violations (RHDHBUGS-2216). Fix the underlying issues in the adoption-insights plugin components: - aria-input-field-name: add aria-label to the date range Select in Header - button-name: add aria-label to the info IconButton in Users/Info - svg-img-alt: add role="img" and aria-label to PieChart and AreaChart - color-contrast: set opaque dark background (#151515) on MUI Tooltips in CatalogEntities, Templates, and Techdocs components Closes #3577
d317ded to
7e158d3
Compare
The aria-label on MUI Select was placed on the OutlinedInput root div which has no valid ARIA role. Moving it to inputProps ensures the label reaches the internal combobox element, fixing the aria-input-field-name axe violation. Addresses review feedback on #3582
🔧 Fix agent — iteration 1 (human-triggered)Fixed aria-input-field-name a11y violation by moving aria-label to inputProps on the MUI Select component in Header.tsx. The label was previously placed on the OutlinedInput root div (no valid ARIA role); inputProps routes it to the internal combobox element. Fixed (1):
Tests: passed Updated by fullsend fix agent |
|



Remove the accessibility violation filter from e2e-tests/utils/accessibility.ts that was suppressing four axe-core violations (RHDHBUGS-2216). Fix the underlying issues in the adoption-insights plugin components:
in CatalogEntities, Templates, and Techdocs components
Closes #3577
Post-script verification
agent/3577-remove-a11y-filter)381f36a38dba5bb09e008fee36bfe722802f4c87..HEAD)