Skip to content

fix(#3577): remove a11y violation filter and fix accessibility issues#3582

Open
fullsend-ai-coder[bot] wants to merge 2 commits into
mainfrom
agent/3577-remove-a11y-filter
Open

fix(#3577): remove a11y violation filter and fix accessibility issues#3582
fullsend-ai-coder[bot] wants to merge 2 commits into
mainfrom
agent/3577-remove-a11y-filter

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Remove the accessibility violation filter from e2e-tests/utils/accessibility.ts that was suppressing four axe-core violations (RHDHBUGS-2216). Fix the underlying issues in the adoption-insights plugin components:

  • aria-input-field-name: add aria-label to the date range Select in Header
  • button-name: add aria-label to the info IconButton in Users/Info
  • svg-img-alt: add role="img" and aria-label to PieChart and AreaChart
  • color-contrast: set opaque dark background (#151515) on MUI Tooltips
    in CatalogEntities, Templates, and Techdocs components

Closes #3577

Post-script verification

  • Branch is not main/master (agent/3577-remove-a11y-filter)
  • Secret scan passed (gitleaks — 381f36a38dba5bb09e008fee36bfe722802f4c87..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

@rhdh-gh-app

rhdh-gh-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @red-hat-developer-hub/backstage-plugin-adoption-insights

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-adoption-insights workspaces/adoption-insights/plugins/adoption-insights none v0.8.3

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.23%. Comparing base (bf40fcb) to head (7fe9f8c).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3582   +/-   ##
=======================================
  Coverage   54.23%   54.23%           
=======================================
  Files        2307     2307           
  Lines       88341    88341           
  Branches    24652    24638   -14     
=======================================
  Hits        47908    47908           
- Misses      40211    40212    +1     
+ Partials      222      221    -1     
Flag Coverage Δ *Carryforward flag
adoption-insights 83.70% <100.00%> (ø)
ai-integrations 67.95% <ø> (ø) Carriedforward from 7e158d3
app-defaults 69.79% <ø> (ø) Carriedforward from 7e158d3
augment 46.39% <ø> (ø) Carriedforward from 7e158d3
boost 74.96% <ø> (ø) Carriedforward from 7e158d3
bulk-import 72.46% <ø> (ø) Carriedforward from 7e158d3
cost-management 14.10% <ø> (ø) Carriedforward from 7e158d3
dcm 61.79% <ø> (ø) Carriedforward from 7e158d3
extensions 61.53% <ø> (ø) Carriedforward from 7e158d3
global-floating-action-button 71.18% <ø> (ø) Carriedforward from 7e158d3
global-header 59.71% <ø> (ø) Carriedforward from 7e158d3
homepage 49.92% <ø> (ø) Carriedforward from 7e158d3
install-dynamic-plugins 56.77% <ø> (ø) Carriedforward from 7e158d3
konflux 91.49% <ø> (ø) Carriedforward from 7e158d3
lightspeed 68.55% <ø> (ø) Carriedforward from 7e158d3
mcp-integrations 85.46% <ø> (ø) Carriedforward from 7e158d3
orchestrator 38.30% <ø> (ø) Carriedforward from 7e158d3
quickstart 63.76% <ø> (ø) Carriedforward from 7e158d3
sandbox 79.56% <ø> (ø) Carriedforward from 7e158d3
scorecard 83.96% <ø> (ø) Carriedforward from 7e158d3
theme 61.26% <ø> (ø) Carriedforward from 7e158d3
translations 7.25% <ø> (ø) Carriedforward from 7e158d3
x2a 78.68% <ø> (ø) Carriedforward from 7e158d3

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf40fcb...7fe9f8c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christoph-jerolimov

Copy link
Copy Markdown
Member

/fs-fix

There are some a11y issue now in the code base. Here are some errors from playwright. Try to fix these issues without changing everything. Keep focused on the specific components.

Array [
  Object {
    "description": "Ensure every ARIA input field has an accessible name",
    "help": "ARIA input fields must have an accessible name",
    "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-input-field-name?application=playwright",
    "id": "aria-input-field-name",
    "impact": "serious",
    "nodes": Array [
      Object {
        "all": Array [],
        "any": Array [
          Object {
            "data": null,
            "id": "aria-label",
            "impact": "serious",
            "message": "aria-label attribute does not exist or is empty",
            "relatedNodes": Array [],
          },
          Object {
            "data": null,
              "role": null,
            },
            "id": "aria-prohibited-attr",
            "impact": "serious",
            "message": "aria-label attribute cannot be used on a div with no valid role attribute.",
            "relatedNodes": Array [],
          },
        ],
        "target": Array [
          ".v5-MuiOutlinedInput-root",
        ],
      },
    ],
    "tags": Array [
      "cat.aria",
      "wcag2a",
      "wcag412",
      "EN-301-549",
      "EN-9.4.1.2",
      "RGAAv4",
      "RGAA-7.1.1",
    ],
  },
]

@fullsend-ai-coder

fullsend-ai-coder Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Finished Fix · ✅ Success · Started 6:38 PM UTC · Completed 6:54 PM UTC
Commit: bf40fcb · View workflow run →

Remove the accessibility violation filter from e2e-tests/utils/accessibility.ts
that was suppressing four axe-core violations (RHDHBUGS-2216). Fix the
underlying issues in the adoption-insights plugin components:

- aria-input-field-name: add aria-label to the date range Select in Header
- button-name: add aria-label to the info IconButton in Users/Info
- svg-img-alt: add role="img" and aria-label to PieChart and AreaChart
- color-contrast: set opaque dark background (#151515) on MUI Tooltips
  in CatalogEntities, Templates, and Techdocs components

Closes #3577
@fullsend-ai-coder fullsend-ai-coder Bot force-pushed the agent/3577-remove-a11y-filter branch from d317ded to 7e158d3 Compare June 25, 2026 18:38
The aria-label on MUI Select was placed on the OutlinedInput root div
which has no valid ARIA role. Moving it to inputProps ensures the label
reaches the internal combobox element, fixing the aria-input-field-name
axe violation.

Addresses review feedback on #3582
@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🔧 Fix agent — iteration 1 (human-triggered)

Fixed aria-input-field-name a11y violation by moving aria-label to inputProps on the MUI Select component in Header.tsx. The label was previously placed on the OutlinedInput root div (no valid ARIA role); inputProps routes it to the internal combobox element.

Fixed (1):

  1. aria-input-field-name violation on MUI Select OutlinedInput root (workspaces/adoption-insights/plugins/adoption-insights/src/components/Header/Header.tsx): Moved aria-label from the Select component prop to inputProps so it reaches the internal combobox element instead of the OutlinedInput root div, which has no valid ARIA role. This fixes the axe aria-input-field-name and aria-prohibited-attr violations.

Tests: passed

Updated by fullsend fix agent

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adoption Insights plugin: Remove accessibility violation filter and fix remaining a11y issues

1 participant