Skip to content

fix(#3577): remove a11y violation filter and fix accessibility issues #3582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-coder wants to merge 2 commits into
base: main
Choose a base branch
from
+41 −17
Open

fix(#3577): remove a11y violation filter and fix accessibility issues #3582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e158d3
fix(#3577): remove a11y violation filter and fix accessibility issues
fullsend-ai-coder[bot] Jun 25, 2026
7fe9f8c
fix: move aria-label to inputProps on Select for a11y compliance
fullsend-ai-coder[bot] Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions workspaces/adoption-insights/e2e-tests/utils/accessibility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,13 @@ export async function runAccessibilityTests(
.withTags(['wcag2a', 'wcag2aa', 'wcag21a', 'wcag21aa'])
.analyze();

// Known violations filtered until fixed in UI; track in https://issues.redhat.com/browse/RHDHBUGS-2216
const filteredViolations = accessibilityScanResults.violations.filter(
v =>
![
'aria-input-field-name',
'button-name',
'color-contrast', // MUI Tooltip default styling
'svg-img-alt', // Recharts pie segments
].includes(v.id),
);

await testInfo.attach(attachName, {
body: JSON.stringify(accessibilityScanResults, null, 2),
contentType: 'application/json',
});

expect(filteredViolations, 'Accessibility violations found').toEqual([]);
expect(
accessibilityScanResults.violations,
'Accessibility violations found',
).toEqual([]);
}
2 changes: 2 additions & 0 deletions ...es/adoption-insights/plugins/adoption-insights/src/components/ActiveUsers/ActiveUsers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ const ActiveUsers = () => {
data={data}
margin={{ top: 10, right: 50, left: 20, bottom: 0 }}
key={JSON.stringify(data.map(d => d))}
role="img"
aria-label={t('activeUsers.title')}
>
<defs>
<linearGradient id="new_users" x1="0" y1="0" x2="0" y2="1">
Expand Down
9 changes: 8 additions & 1 deletion ...ion-insights/plugins/adoption-insights/src/components/CatalogEntities/CatalogEntities.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,14 @@ const CatalogEntities = () => {
}}
>
<TableCell sx={{ width: '25%', minWidth: 0 }}>
<Tooltip title={tooltipTitle}>
<Tooltip
title={tooltipTitle}
componentsProps={{
tooltip: {
sx: { bgcolor: '#151515', color: '#ffffff' },
},
}}
>
<Link
component="a"
href={entityLink({
Expand Down
1 change: 1 addition & 0 deletions workspaces/adoption-insights/plugins/adoption-insights/src/components/Header/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ const InsightsHeader: FC<InsightsHeaderProps> = () => {
value={selectedOption}
onChange={handleChange}
renderValue={(selected: string) => getLabel(selected)}
inputProps={{ 'aria-label': t('header.dateRange.defaultLabel') }}
sx={{
minWidth: 190,
marginRight: '10px',
Expand Down
9 changes: 8 additions & 1 deletion workspaces/adoption-insights/plugins/adoption-insights/src/components/Techdocs/Techdocs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,14 @@ const Techdocs = () => {
</TableCell>
<TableCell sx={{ width: '25%', minWidth: 0 }}>
{techdoc?.name ? (
<Tooltip title={tooltipTitle}>
<Tooltip
title={tooltipTitle}
componentsProps={{
tooltip: {
sx: { bgcolor: '#151515', color: '#ffffff' },
},
}}
>
<Link
component="a"
target="_blank"
Expand Down
9 changes: 8 additions & 1 deletion ...spaces/adoption-insights/plugins/adoption-insights/src/components/Templates/Templates.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,14 @@ const Templates = () => {
minWidth: 0,
}}
>
<Tooltip title={tooltipTitle}>
<Tooltip
title={tooltipTitle}
componentsProps={{
tooltip: {
sx: { bgcolor: '#151515', color: '#ffffff' },
},
}}
>
<Link
component="a"
href={entityHrefLink}
Expand Down
2 changes: 1 addition & 1 deletion workspaces/adoption-insights/plugins/adoption-insights/src/components/Users/Info.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const InfoComponent = () => {
},
}}
>
<IconButton>
<IconButton aria-label={t('users.tooltip')}>
<InfoOutlinedIcon
sx={{ color: theme.palette.text.secondary, fontSize: '1.75rem' }}
/>
Expand Down
10 changes: 9 additions & 1 deletion workspaces/adoption-insights/plugins/adoption-insights/src/components/Users/Users.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,15 @@ const Users = () => {
<Box display="flex" alignItems="center" flex={7}>
<Box sx={{ width: '100%', maxWidth: '240px' }}>
<ResponsiveContainer width="100%" height={240}>
<PieChart>
<PieChart
role="img"
aria-label={`${t(
'users.title',
)}: ${logged_in_users.toLocaleString('en-US')} ${t(
'users.ofTotal' as any,
{ total: licensed_users.toLocaleString('en-US') },
)}`}
>
<Pie
data={data}
dataKey="value"
Expand Down
Loading