feat(#3591): enable accessibility violation assertions in theme e2e tests#3594
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
feat(#3591): enable accessibility violation assertions in theme e2e tests#3594fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
…ests
Remove the `skipViolationsAssert` option from `runAccessibilityTests`
in both `packages/app` and `packages/app-legacy` e2e test utilities.
The function now always asserts that axe-core finds zero WCAG
violations, making accessibility checks enforced rather than advisory.
Changes:
- Remove `skipViolationsAssert` parameter from the options type and
the conditional guard in both `acessibility.ts` files
- Remove `{ skipViolationsAssert: true }` from all call sites in
both `custom-theme.spec.ts` files
- The expect assertion now runs unconditionally after every axe scan
Note: Pre-commit hook failed due to pre-existing lint errors
(`@backstage/no-undeclared-imports` for `@playwright/test` in
`packages/app` e2e-tests). These errors exist on main and are not
introduced by this change. Playwright e2e tests require a running
app and browser, so they could not be executed in this sandbox.
Manual verification of `CI=1 yarn test:e2e` is required to identify
and fix any remaining a11y violations surfaced by the now-enforced
assertions.
Closes #3591
fullsend-ai-coder
Bot
requested review from
a team,
ciiay and
logonoff
as code owners
Changed Packages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3594 +/- ##
=======================================
Coverage 53.09% 53.09%
=======================================
Files 2306 2306
Lines 88276 88276
Branches 24567 24567
=======================================
Hits 46873 46873
Misses 41051 41051
Partials 352 352
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
skipViolationsAssertoption fromrunAccessibilityTestsin bothpackages/appandpackages/app-legacye2e test utilities. The function now always asserts that axe-core finds zero WCAG violations, making accessibility checks enforced rather than advisory.Changes:
skipViolationsAssertparameter from the options type andthe conditional guard in both
acessibility.tsfiles{ skipViolationsAssert: true }from all call sites inboth
custom-theme.spec.tsfilesNote: Pre-commit hook failed due to pre-existing lint errors (
@backstage/no-undeclared-importsfor@playwright/testinpackages/appe2e-tests). These errors exist on main and are not introduced by this change. Playwright e2e tests require a running app and browser, so they could not be executed in this sandbox. Manual verification ofCI=1 yarn test:e2eis required to identify and fix any remaining a11y violations surfaced by the now-enforced assertions.Closes #3591
Post-script verification
agent/3591-enable-a11y-checks)4866641df899e78f168c77d1266ed4c8bd249149..HEAD)