Skip to content

feat(#3591): enable accessibility violation assertions in theme e2e tests #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-coder wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −34
Open

feat(#3591): enable accessibility violation assertions in theme e2e tests #3594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions workspaces/theme/packages/app-legacy/e2e-tests/custom-theme.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,7 @@ test.describe('CustomTheme should be applied', () => {
}, testInfo: TestInfo) => {
const themes = ThemeConstants.getThemes();

await runAccessibilityTests(
page,
testInfo,
'accessibility-scan-results.json',
{ skipViolationsAssert: true },
);
await runAccessibilityTests(page, testInfo);

for (const theme of themes) {
await themeVerifier.setTheme(theme.name);
Expand Down Expand Up @@ -86,15 +81,13 @@ test.describe('CustomTheme should be applied', () => {
page,
testInfo,
`${themeName}-${tab}-accessibility`,
{ skipViolationsAssert: true },
);
for (const subTab of subTabs) {
await page.getByRole('tab', { name: subTab }).click();
await runAccessibilityTests(
page,
testInfo,
`${themeName}-${tab}-${subTab}-accessibility`,
{ skipViolationsAssert: true },
);
}
}
Expand Down
13 changes: 4 additions & 9 deletions workspaces/theme/packages/app-legacy/e2e-tests/utils/acessibility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ export async function runAccessibilityTests(
page: Page,
testInfo: TestInfo,
attachName = 'accessibility-scan-results.json',
options: { skipViolationsAssert?: boolean; attachName?: string } = {
skipViolationsAssert: false,
},
) {
const accessibilityScanResults = await new AxeBuilder({ page })
.withTags(['wcag2a', 'wcag2aa', 'wcag21a', 'wcag21aa'])
Expand All @@ -33,10 +30,8 @@ export async function runAccessibilityTests(
contentType: 'application/json',
});

if (!options?.skipViolationsAssert) {
expect(
accessibilityScanResults.violations,
'Accessibility violations found',
).toEqual([]);
}
expect(
accessibilityScanResults.violations,
'Accessibility violations found',
).toEqual([]);
}
9 changes: 1 addition & 8 deletions workspaces/theme/packages/app/e2e-tests/custom-theme.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,7 @@ test.describe('CustomTheme should be applied', () => {
}, testInfo: TestInfo) => {
const themes = ThemeConstants.getThemes();

await runAccessibilityTests(
page,
testInfo,
'accessibility-scan-results.json',
{ skipViolationsAssert: true },
);
await runAccessibilityTests(page, testInfo);

for (const theme of themes) {
await themeVerifier.setTheme(theme.name);
Expand Down Expand Up @@ -82,15 +77,13 @@ test.describe('CustomTheme should be applied', () => {
page,
testInfo,
`${themeName}-${tab}-accessibility`,
{ skipViolationsAssert: true },
);
for (const subTab of subTabs) {
await page.getByRole('tab', { name: subTab }).click();
await runAccessibilityTests(
page,
testInfo,
`${themeName}-${tab}-${subTab}-accessibility`,
{ skipViolationsAssert: true },
);
}
}
Expand Down
13 changes: 4 additions & 9 deletions workspaces/theme/packages/app/e2e-tests/utils/acessibility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ export async function runAccessibilityTests(
page: Page,
testInfo: TestInfo,
attachName = 'accessibility-scan-results.json',
options: { skipViolationsAssert?: boolean; attachName?: string } = {
skipViolationsAssert: false,
},
) {
const accessibilityScanResults = await new AxeBuilder({ page })
.withTags(['wcag2a', 'wcag2aa', 'wcag21a', 'wcag21aa'])
Expand All @@ -33,10 +30,8 @@ export async function runAccessibilityTests(
contentType: 'application/json',
});

if (!options?.skipViolationsAssert) {
expect(
accessibilityScanResults.violations,
'Accessibility violations found',
).toEqual([]);
}
expect(
accessibilityScanResults.violations,
'Accessibility violations found',
).toEqual([]);
}
Loading