fix(#3590): remove a11y violation filter and fix icon button accessibility#3596
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#3590): remove a11y violation filter and fix icon button accessibility#3596fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
…ility Remove the button-name accessibility violation filter from runAccessibilityTests in the e2e test utility. The filter was suppressing real axe-core violations for icon-only buttons lacking accessible names. Fix the root cause by adding an aria-label to the CardInfoButton IconButton component, which was the only icon button missing an accessible name. The pagination buttons already had aria-label attributes. Add the new lastUpdatedInfoButton translation key to the English reference and all five language files (de, es, fr, it, ja) so the aria-label is properly internationalized. Regenerated API reports to reflect the new translation key. Closes #3590
fullsend-ai-coder
Bot
requested review from
a team,
Eswaraiahsapram,
christoph-jerolimov and
its-mitesh-kumar
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
|
|
🤖 Finished Review · ✅ Success · Started 12:11 AM UTC · Completed 12:17 AM UTC |
|
Looks good to me |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the button-name accessibility violation filter from runAccessibilityTests in the e2e test utility. The filter was suppressing real axe-core violations for icon-only buttons lacking accessible names.
Fix the root cause by adding an aria-label to the CardInfoButton IconButton component, which was the only icon button missing an accessible name. The pagination buttons already had aria-label attributes.
Add the new lastUpdatedInfoButton translation key to the English reference and all five language files (de, es, fr, it, ja) so the aria-label is properly internationalized.
Regenerated API reports to reflect the new translation key.
Closes #3590
Post-script verification
agent/3590-remove-a11y-violation-filter)4866641df899e78f168c77d1266ed4c8bd249149..HEAD)