Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,8 @@ export async function runAccessibilityTests(
contentType: 'application/json',
});

// Ignore button-name for icon-only buttons that have a tooltip (e.g. scorecard "Last updated" info icon)
const filteredViolations = accessibilityScanResults.violations.filter(
v => v.id !== 'button-name',
);

expect(filteredViolations, 'Accessibility violations found').toEqual([]);
expect(
accessibilityScanResults.violations,
'Accessibility violations found',
).toEqual([]);
}
5 changes: 3 additions & 2 deletions workspaces/scorecard/plugins/scorecard/report-alpha.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ const _default: OverridableFrontendPlugin<
{
root: RouteRef<undefined>;
drillDown: RouteRef<{
aggregationId: string;
metricId: string;
aggregationId: string;
}>;
},
{},
Expand Down Expand Up @@ -59,14 +59,14 @@ const _default: OverridableFrontendPlugin<
};
output:
| ExtensionDataRef<string, 'core.routing.path', {}>
| ExtensionDataRef<JSX_2.Element, 'core.reactElement', {}>
| ExtensionDataRef<
RouteRef_2<AnyRouteRefParams>,
'core.routing.ref',
{
optional: true;
}
>
| ExtensionDataRef<JSX_2.Element, 'core.reactElement', {}>
| ExtensionDataRef<
string,
'core.title',
Expand Down Expand Up @@ -197,6 +197,7 @@ export const scorecardTranslationRef: TranslationRef<
readonly 'metric.filecheck.description': string;
readonly 'metric.lastUpdated': string;
readonly 'metric.lastUpdatedNotAvailable': string;
readonly 'metric.lastUpdatedInfoButton': string;
readonly 'metric.someEntitiesNotReportingValues': string;
readonly 'metric.averageCenterTooltipTotalLabel': string;
readonly 'metric.averageCenterTooltipMaxLabel': string;
Expand Down
1 change: 1 addition & 0 deletions workspaces/scorecard/plugins/scorecard/report.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ export const scorecardTranslationRef: TranslationRef<
readonly 'metric.filecheck.description': string;
readonly 'metric.lastUpdated': string;
readonly 'metric.lastUpdatedNotAvailable': string;
readonly 'metric.lastUpdatedInfoButton': string;
readonly 'metric.someEntitiesNotReportingValues': string;
readonly 'metric.averageCenterTooltipTotalLabel': string;
readonly 'metric.averageCenterTooltipMaxLabel': string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ export const CardInfoButton = ({ timestamp }: { timestamp: string }) => {
},
}}
>
<IconButton data-testid="scorecard-homepage-card-info">
<IconButton
data-testid="scorecard-homepage-card-info"
aria-label={t('metric.lastUpdatedInfoButton')}
>
<InfoOutlinedIcon
sx={{ color: theme.palette.text.secondary, fontSize: '1.75rem' }}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ const scorecardTranslationDe = createTranslationMessages({
'metric.jira.open_issues.title': 'Jira-Tickets öffnen und blockieren',
'metric.lastUpdated': 'Letzte Aktualisierung: {{timestamp}}',
'metric.lastUpdatedNotAvailable': 'Letzte Aktualisierung: Nicht verfügbar',
'metric.lastUpdatedInfoButton': 'Informationen zur letzten Aktualisierung',
'metric.someEntitiesNotReportingValues':
'Einige Organisationen melden keine Werte, die sich auf diese Kennzahl beziehen.',
'metric.sonarqube.code_coverage.description':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ const scorecardTranslationEs = createTranslationMessages({
'metric.jira.open_issues.title': 'Tickets de bloqueo abiertos en Jira',
'metric.lastUpdated': 'Última actualización: {{timestamp}}',
'metric.lastUpdatedNotAvailable': 'Última actualización: no disponible',
'metric.lastUpdatedInfoButton': 'Información de última actualización',
'metric.someEntitiesNotReportingValues':
'Algunas entidades no informan valores relacionados con esta métrica.',
'metric.sonarqube.code_coverage.description':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ const scorecardTranslationFr = createTranslationMessages({
'metric.jira.open_issues.title': 'Tickets de blocage ouverts Jira',
'metric.lastUpdated': 'Dernière mise à jour : {{timestamp}}',
'metric.lastUpdatedNotAvailable': 'Dernière mise à jour : Non disponible',
'metric.lastUpdatedInfoButton': 'Informations sur la dernière mise à jour',
'metric.someEntitiesNotReportingValues':
'Certaines entités ne communiquent pas les valeurs relatives à cet indicateur.',
'metric.sonarqube.code_coverage.description':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ const scorecardTranslationIt = createTranslationMessages({
'metric.jira.open_issues.title': 'Ticket di blocco aperti in Jira',
'metric.lastUpdated': 'Ultimo aggiornamento: {{timestamp}}',
'metric.lastUpdatedNotAvailable': 'Ultimo aggiornamento: non disponibile',
'metric.lastUpdatedInfoButton': "Informazioni sull'ultimo aggiornamento",
'metric.someEntitiesNotReportingValues':
'Alcune entità non comunicano i valori relativi a questa metrica.',
'metric.sonarqube.code_coverage.description':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ const scorecardTranslationJa = createTranslationMessages({
'Jira のオープン状態の進行を妨げているチケット',
'metric.lastUpdated': '最終更新: {{timestamp}}',
'metric.lastUpdatedNotAvailable': '最終更新: 利用不可',
'metric.lastUpdatedInfoButton': '最終更新情報',
'metric.someEntitiesNotReportingValues':
'このメトリクスに関連する値を報告していないエンティティーがあります。',
'metric.sonarqube.code_coverage.description':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ export const scorecardMessages = {
},
lastUpdated: 'Last updated: {{timestamp}}',
lastUpdatedNotAvailable: 'Last updated: Not available',
lastUpdatedInfoButton: 'Last updated info',
someEntitiesNotReportingValues:
'Some entities are not reporting values related to this metric.',
averageCenterTooltipTotalLabel: 'Total score',
Expand Down
Loading