fix(lightspeed): keep MCP settings panel open in fullscreen mode and fix display mode selector focus#3604
Open
teknaS47 wants to merge 1 commit into
Open
fix(lightspeed): keep MCP settings panel open in fullscreen mode and fix display mode selector focus#3604teknaS47 wants to merge 1 commit into
teknaS47 wants to merge 1 commit into
Conversation
…fix display mode selector focus Signed-off-by: Sanket Saikia <sanketsaikia13@gmail.com>
teknaS47
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
Changed Packages
|
|
HusneShabbir
left a comment
HusneShabbir
left a comment
Member
There was a problem hiding this comment.
cc: @its-mitesh-kumar / @ciiay
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3604 +/- ##
==========================================
- Coverage 54.21% 54.21% -0.01%
==========================================
Files 2312 2312
Lines 88532 88536 +4
Branches 24661 24656 -5
==========================================
Hits 48000 48000
- Misses 39040 39044 +4
Partials 1492 1492
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3384
Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3415
RHDHBUGS-3384: The MCP settings panel was closing whenever the user started a new chat, selected a conversation, or changed a model in fullscreen mode. This was because
setIsMcpSettingsOpen(false)was called unconditionally. Now we only close the panel in non-fullscreen (drawer/overlay) modes, where the panel overlaps the chat.RHDHBUGS-3415: The options dropdown (
ChatbotHeaderOptionsDropdown) was auto-focusing its first menu item on open, causing unintended keyboard/focus behavior. AddedshouldFocusFirstItemOnOpen={false}to prevent this.✔️ Checklist
Screen recording:
Screen.Recording.2026-06-26.at.10.04.47.PM.mov