Skip to content

fix(lightspeed): keep MCP settings panel open in fullscreen mode and fix display mode selector focus #3604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teknaS47 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(lightspeed): keep MCP settings panel open in fullscreen mode and fix display mode selector focus #3604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions workspaces/lightspeed/.changeset/chilled-carrots-boil.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@red-hat-developer-hub/backstage-plugin-lightspeed': patch
---

Fix MCP settings panel and options dropdown behavior:

- Keep MCP settings panel open during navigation in fullscreen mode
- Prevent options dropdown from auto-focusing first item on open
17 changes: 13 additions & 4 deletions workspaces/lightspeed/plugins/lightspeed/src/components/LightSpeedChat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,7 +1111,9 @@ export const LightspeedChat = ({

const onNewChat = useCallback(() => {
(async () => {
setIsMcpSettingsOpen(false);
if (!isFullscreenMode) {
setIsMcpSettingsOpen(false);
}
if (conversationId !== TEMP_CONVERSATION_ID) {
setMessages([]);
setFileContents([]);
Expand Down Expand Up @@ -1342,7 +1344,9 @@ export const LightspeedChat = ({

const onSelectActiveItem = useCallback(
(_: MouseEvent | undefined, selectedItem: string | number | undefined) => {
setIsMcpSettingsOpen(false);
if (!isFullscreenMode) {
setIsMcpSettingsOpen(false);
}
setNewChatCreated(false);
const newConvId = String(selectedItem);
setConversationId((c_id: string) => {
Expand All @@ -1365,6 +1369,7 @@ export const LightspeedChat = ({
scrollToBottomRef,
setCurrentConversationId,
setIsMcpSettingsOpen,
isFullscreenMode,
],
);

Expand Down Expand Up @@ -1779,7 +1784,9 @@ export const LightspeedChat = ({
selectedModel={selectedModel}
models={models}
onSelect={item => {
setIsMcpSettingsOpen(false);
if (!isFullscreenMode) {
setIsMcpSettingsOpen(false);
}
onNewChat();
handleSelectedModel(item);
}}
Expand Down Expand Up @@ -1947,7 +1954,9 @@ export const LightspeedChat = ({
<LightspeedChatBoxHeader
selectedModel={selectedModel}
handleSelectedModel={item => {
setIsMcpSettingsOpen(false);
if (!isFullscreenMode) {
setIsMcpSettingsOpen(false);
}
onNewChat();
handleSelectedModel(item);
}}
Expand Down
1 change: 1 addition & 0 deletions workspaces/lightspeed/plugins/lightspeed/src/components/LightspeedChatBoxHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ export const LightspeedChatBoxHeader = ({
<ChatbotHeaderOptionsDropdown
className={styles.dropdown}
isCompact
shouldFocusFirstItemOnOpen={false}
toggleProps={{
'aria-label': t('aria.options.label'),
className: styles.optionsToggle,
Expand Down
Loading