feat(e2e): strict oxlint, oxfmt, and type-aware linting#5002
Merged
Conversation
Contributor
|
The container image build workflow finished with status: |
Contributor
|
The container image build workflow finished with status: |
Contributor
|
The container image build workflow finished with status: |
Contributor
|
The container image build workflow finished with status: |
Contributor
|
The container image build workflow finished with status: |
This was referenced Jun 23, 2026
schultzp2020
force-pushed
the
feat/e2e-oxc-toolchain
branch
from
390f0e8 to
782f16b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5002 +/- ##
==========================================
- Coverage 55.39% 54.77% -0.62%
==========================================
Files 122 110 -12
Lines 2365 2147 -218
Branches 539 537 -2
==========================================
- Hits 1310 1176 -134
+ Misses 1049 969 -80
+ Partials 6 2 -4
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
schultzp2020
force-pushed
the
feat/e2e-oxc-toolchain
branch
from
75bf7b2 to
40d0f7d
Compare
jonkoops
approved these changes
Jun 24, 2026
|
New changes are detected. LGTM label has been removed. |
Contributor
|
The container image build workflow finished with status: |
Contributor
|
The container image build workflow finished with status: |
Replace ESLint, Prettier, and tsc:check with oxlint --type-aware --type-check and oxfmt in e2e-tests. Add waitForConfigReconciled() for auth provider rollout waits and remove hard waitForTimeout usage across specs and helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
Set strict: true in e2e-tests tsconfig and fix ~235 type errors across specs and utilities with proper guards, error helpers, and typing. Co-authored-by: Cursor <cursoragent@cursor.com>
Map existing yarn scripts to oxlint and oxfmt so docs, CI, and lint-staged keep using lint:check, lint:fix, prettier:check, prettier:fix, and tsc:check. Co-authored-by: Cursor <cursoragent@cursor.com>
Use lint/lint:fix and fmt/fmt:check script names, remove tsc and legacy prettier script aliases. Type-aware settings remain in oxlint.config.ts. Co-authored-by: Cursor <cursoragent@cursor.com>
Add import, node, and promise plugins with suspicious-as-error categories, promote Playwright and type-aware unsafe-* rules to error, and fix the resulting violations across helpers, specs, and support code. Co-authored-by: Cursor <cursoragent@cursor.com>
Use single-source-of-truth const tuples for Locale and audit log enums, and loop LOCALES when merging translation bundles. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Oxlint no-empty-pattern conflicted with Playwright's required `{}` callback
shape; the _args workaround passed lint but broke test collection in Prow.
Disable no-empty-pattern for spec files and add yarn test:list to GHA.
Co-authored-by: Cursor <cursoragent@cursor.com>
Restore Log stack parsing dropped by the typed constructor refactor, use .first() for ambiguous increment buttons after locator migration, and revert annotator catalog check to verifyText which handles duplicates. Co-authored-by: Cursor <cursoragent@cursor.com>
Revert application-provider to per-card DOM selectors that avoid strict mode on shared article headings, and stop expecting undefined from registerExistingComponent which returns a boolean. Co-authored-by: Cursor <cursoragent@cursor.com>
…ators Replace file-level no-raw-locators override with a scoped block comment next to the nested div card selectors, matching repo convention. Co-authored-by: Cursor <cursoragent@cursor.com>
Await whitelisted POM helpers directly instead of expect().resolves.toBeUndefined(), revert inline locators to uiHelper.verify* where helpers encode strictness, and drop redundant post-YAML expects covered by inspectEntityAndVerifyYaml. Co-authored-by: Cursor <cursoragent@cursor.com>
schultzp2020
force-pushed
the
feat/e2e-oxc-toolchain
branch
from
b499d8d to
31ffed4
Compare
Contributor
|
The container image build workflow finished with status: |
Use Oxfmt-recommended defaults (printWidth 100, sortPackageJson) and enable sortImports. Reformat the full e2e-tests tree so fmt:check stays green. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Merging as the last run was green and the only new change is to enable import sorting. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 2 in the E2E modernization stack (after merged #5000).
e2e-tests/from ESLint + Prettier +tsc:checkto oxlint (type-aware + type-check) and oxfmte2e-tests/tsconfig.jsonand fix ~235 type errors across specs and utilitiesimport,node,promise) with suspicious-as-error categories; promote Playwright and unsafe-* rules to erroreslint-plugin-playwrightand file naming viaeslint-plugin-check-filewaitForConfigReconciled()inRHDHDeploymentand remove hardwaitForTimeoutcalls from auth-provider specsas consttuples (single source of truth)testInfohook destructuring, audit-log parsing, card scoping, helper-based assertionse2e-tests-lint.yamland lint-staged; addyarn test:listto CI so Playwright collection regressions fail in GHAMerge order
feat/e2e-oxc-toolchain)Test plan
cd e2e-tests && yarn lint— 0 errorscd e2e-tests && yarn fmt:check— cleancd e2e-tests && yarn test:list— Playwright collects all specse2e-tests-lintand Prow e2e jobs greenNotes
strict: truein e2e-tests tsconfig; type-aware oxlint rules enforce safety without a separatetsc:checkstep