feat(e2e): enable oxlint pedantic category#5003
Merged
Merged
Conversation
5 tasks
schultzp2020
force-pushed
the
feat/e2e-oxc-toolchain
branch
from
390f0e8 to
782f16b
Compare
schultzp2020
force-pushed
the
feat/e2e-oxlint-pedantic
branch
from
e403a5f to
002da5f
Compare
Contributor
|
The container image build workflow finished with status: |
Contributor
|
The container image build workflow finished with status: |
Contributor
|
❌ The last analysis has failed. |
schultzp2020
force-pushed
the
feat/e2e-oxc-toolchain
branch
from
75bf7b2 to
40d0f7d
Compare
schultzp2020
force-pushed
the
feat/e2e-oxlint-pedantic
branch
from
002da5f to
fa8b88e
Compare
schultzp2020
force-pushed
the
feat/e2e-oxlint-pedantic
branch
from
fa8b88e to
c9f8ecd
Compare
schultzp2020
force-pushed
the
feat/e2e-oxlint-pedantic
branch
from
c9f8ecd to
5a38cc9
Compare
schultzp2020
force-pushed
the
feat/e2e-oxc-toolchain
branch
from
b499d8d to
31ffed4
Compare
Contributor
|
The container image build workflow finished with status: |
Contributor
Contributor
4 tasks
schultzp2020
force-pushed
the
feat/e2e-oxlint-pedantic
branch
from
168c0ca to
38d863d
Compare
Contributor
Turn on pedantic-as-error with prefer-readonly-parameter-types disabled for test helpers, then fix ~635 violations via stricter booleans, nullish coalescing, module splits for oversized files, and deprecated selector migrations. Co-authored-by: Cursor <cursoragent@cursor.com>
Use directory globs instead of named files and document the rationale for each override block. Co-authored-by: Cursor <cursoragent@cursor.com>
Use plain await for deployment restart, expect().toBeVisible() for the About card link, and table-scoped verifyText for catalog Name checks. Register restartDeployment as an assert helper for expect-expect. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
schultzp2020
force-pushed
the
feat/e2e-oxlint-pedantic
branch
from
38d863d to
647a166
Compare
Contributor
Move kube-client, api-helper, common, rhdh-deployment, and semantic selector splits into directories with short filenames, matching the ui-helper pattern. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Remove redundant top-level common.ts and ui-helper.ts facades so split modules match api-helper and kube-client (folder + index only). Add ui-helper/index.ts and move msgraph-helper split into msgraph-helper/. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Folder moves left one-level-too-shallow paths to errors, api-endpoints, support, and locale modules, which broke type-aware oxlint in CI. Use global fetch in keycloak helper now that Node 24 provides it natively. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Semantic getAccordion/getCard/getTableRow locators were too narrow or ambiguous for MUI home page and scaffolder review tables. Scope quick access items to the accordion root, cards via MuiCard XPath, and rows via :text-is() matching until semantic selectors cover these layouts. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5003 +/- ##
==========================================
- Coverage 55.39% 54.77% -0.62%
==========================================
Files 122 110 -12
Lines 2365 2147 -218
Branches 563 538 -25
==========================================
- Hits 1310 1176 -134
+ Misses 1048 969 -79
+ Partials 7 2 -5
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
jonkoops
approved these changes
Jun 25, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 3 in the E2E modernization stack (builds on #5002).
pedantic: "error"ine2e-tests/oxlint.config.tstypescript/prefer-readonly-parameter-types— low ROI for PlaywrightPage/ API helpers (~408 noise)??coalescing, unicode regex flags, inline comment cleanup,require-awaitcleanupkube-client,rhdh-deployment,ui-helper,semantic-selectors,api-helper,common) to satisfy max-lines/max-depthUI_HELPER_ELEMENTS/MuiCardselectors toward semantic locators andui-locators.tsrestartDeploymentdirectly,expect().toBeVisible()for About card, table-scoped catalog Name checks; registerrestartDeploymentforexpect-expectMerge order
feat/e2e-oxlint-pedantic)Test plan
cd e2e-tests && yarn lint— 0 errorscd e2e-tests && yarn fmt:check— cleane2e-tests-lintgreen (after feat(e2e): strict oxlint, oxfmt, and type-aware linting #5002 merges)