chore: sync from monorepo @9b81d97#38
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 51 minutes and 36 seconds.Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request updates several Microsoft Extensions packages to version 10.0.7. Feedback indicates that the update to Microsoft.Extensions.Http.Polly may be inappropriate as it is a legacy integration for Polly v7, whereas the codebase utilizes Polly v8; migrating to Microsoft.Extensions.Http.Resilience is recommended. Additionally, the reviewer noted that these dependencies might be unused or should be properly leveraged through IHttpClientFactory rather than direct HttpClient instantiation.
| <PackageVersion Include="Microsoft.Extensions.Http" Version="10.0.7" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Http.Polly" Version="10.0.7" /> |
There was a problem hiding this comment.
The update to Microsoft.Extensions.Http.Polly (v10.0.7) appears inconsistent with the codebase's adoption of Polly v8 resilience pipelines (as seen in BaseServiceClient.cs). Microsoft.Extensions.Http.Polly is the legacy integration for Polly v7 'Policies'. For Polly v8, the official integration is Microsoft.Extensions.Http.Resilience. Additionally, since the current client implementations instantiate HttpClient directly rather than using IHttpClientFactory, these dependencies might be unused or should be leveraged via the factory pattern for better resource management and DNS handling.
Automated sync from resq-software/resQ@
9b81d97.Review before merging — direct pushes to standalone repos are preserved.