Skip to content

chore: sync from monorepo @9b81d97 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WomB0ComB0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: sync from monorepo @9b81d97 #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
<PackageVersion Include="Grpc.Tools" Version="2.80.0" />

<!-- Service Clients & HTTP -->
<PackageVersion Include="Microsoft.Extensions.Http" Version="10.0.6" />
<PackageVersion Include="Microsoft.Extensions.Http.Polly" Version="10.0.6" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.6" />
<PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.6" />
<PackageVersion Include="Microsoft.Extensions.Http" Version="10.0.7" />
<PackageVersion Include="Microsoft.Extensions.Http.Polly" Version="10.0.7" />
Comment on lines +21 to +22
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The update to Microsoft.Extensions.Http.Polly (v10.0.7) appears inconsistent with the codebase's adoption of Polly v8 resilience pipelines (as seen in BaseServiceClient.cs). Microsoft.Extensions.Http.Polly is the legacy integration for Polly v7 'Policies'. For Polly v8, the official integration is Microsoft.Extensions.Http.Resilience. Additionally, since the current client implementations instantiate HttpClient directly rather than using IHttpClientFactory, these dependencies might be unused or should be leveraged via the factory pattern for better resource management and DNS handling.

Copy link
Copy Markdown
Member Author

@WomB0ComB0 WomB0ComB0 May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: @WomB0ComB0

<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.7" />
<PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.7" />
<PackageVersion Include="Polly" Version="8.6.6" />
<PackageVersion Include="Polly.Extensions.Http" Version="3.0.0" />
<PackageVersion Include="System.Text.Json" Version="9.0.14" />
Expand Down
Loading