chore: upgrade CI/CD pipeline with comprehensive testing and code qua… by rilma · Pull Request #40 · rilma/pyIRI2016

rilma · 2026-02-21T19:53:01Z

…lity checks

Replace minimal smoke.yml with full CI workflow (build-and-test, lint, typecheck jobs)
Add multi-version testing (Python 3.11 for now)
Implement code quality checks: ruff (lint/format) and mypy (type checking)
Add .pre-commit-config.yaml for local development workflow
Update pyproject.toml with tool.ruff and tool.mypy configuration
Add Makefile targets: lint, lint-fix, format, typecheck, pre-commit
Update Makefile dev targets to install ruff and mypy
Add coverage reporting to CI pipeline with Codecov integration
Update README with badges and new command documentation

Addresses issue #12: CI/CD improvements

…lity checks - Replace minimal smoke.yml with full CI workflow (build-and-test, lint, typecheck jobs) - Add multi-version testing (Python 3.11, 3.12, 3.13) - Implement code quality checks: ruff (lint/format) and mypy (type checking) - Add .pre-commit-config.yaml for local development workflow - Update pyproject.toml with tool.ruff and tool.mypy configuration - Add Makefile targets: lint, lint-fix, format, typecheck, pre-commit - Update Makefile dev targets to install ruff and mypy - Add coverage reporting to CI pipeline with Codecov integration - Update README with badges and new command documentation Addresses issue #12: CI/CD improvements

Copilot

Pull request overview

This PR comprehensively upgrades the CI/CD pipeline to add automated testing, linting, and type checking, addressing issue #12. The changes introduce ruff for code formatting/linting and mypy for type checking, along with pre-commit hooks for local development. All Python code has been reformatted to follow the new standards (double quotes, 100-character line length, consistent formatting).

Changes:

Replaced minimal smoke.yml workflow with a full CI pipeline featuring three jobs: build-and-test, lint, and typecheck
Added ruff and mypy as code quality tools with configuration in pyproject.toml and .pre-commit-config.yaml
Reformatted all Python files to use double quotes, improved formatting, and removed unused imports (notably seaborn)

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
.github/workflows/smoke.yml	Upgraded from single smoke test to 3-job CI pipeline with build-and-test, lint, and typecheck jobs
.pre-commit-config.yaml	Added pre-commit hooks for ruff linting/formatting and mypy type checking
pyproject.toml	Added tool configurations for ruff, mypy, and pytest
Makefile	Added new targets: lint, lint-fix, format, typecheck, pre-commit
README.md	Updated badges and added documentation for new quality check commands
CHANGELOG.md	Documented CI/CD improvements and new tooling
pyiri2016/init.py	Reformatted with double quotes, improved spacing and function call formatting
pyiri2016/iri2016prof2D.py	Reformatted imports, strings, and function calls; removed unused seaborn import
pyiri2016/api/update.py	Reformatted with consistent quote style and spacing
tests/test_api.py	Reformatted and removed unused result variable
tests/test.py	Reformatted with double quotes and improved formatting
settings/settings.py	Reformatted with double quotes
examples/*.py	Reformatted all example files, removed unused seaborn imports
scripts/*.py	Reformatted all script files, removed unused seaborn imports, improved function call formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/smoke.yml

README.md

.github/workflows/smoke.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/smoke.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pyproject.toml

tests/test_api.py

pyiri2016/api/update.py

.github/workflows/smoke.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-02-21T20:58:59Z

@rilma I've opened a new pull request, #41, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-21T20:59:34Z

@rilma I've opened a new pull request, #42, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…rror Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

…ed with correct URL Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CHANGELOG.md

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pyiri2016/api/update.py

.github/workflows/smoke.yml

pyiri2016/api/update.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-02-21T21:30:18Z

@rilma I've opened a new pull request, #43, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pyproject.toml

Makefile

.github/workflows/smoke.yml

tests/test_api.py

pyiri2016/api/update.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-02-21T21:51:00Z

@rilma I've opened a new pull request, #44, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-21T21:51:27Z

@rilma I've opened a new pull request, #45, to work on those changes. Once the pull request is ready, I'll request review from you.

…eve() Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

rilma and others added 6 commits February 21, 2026 20:50

docs: update CHANGELOG with CI/CD improvements (issue #12)

cadd44d

ruff impro

ec71ce9

ruff fix

2872f41

mypy fixes

a78179b

single Python version only

e0511b4

rilma requested a review from Copilot February 21, 2026 20:14

Copilot started reviewing on behalf of rilma February 21, 2026 20:15 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

.github/workflows/smoke.yml Outdated Show resolved Hide resolved

.github/workflows/smoke.yml Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

.github/workflows/smoke.yml Show resolved Hide resolved

rilma and others added 3 commits February 21, 2026 21:41

Update .github/workflows/smoke.yml

2fe1a2d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update .github/workflows/smoke.yml

e1ad012

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update README.md

a358f77

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rilma requested a review from Copilot February 21, 2026 20:42

Copilot started reviewing on behalf of rilma February 21, 2026 20:43 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

.github/workflows/smoke.yml Outdated Show resolved Hide resolved

Update .github/workflows/smoke.yml

9d10895

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rilma requested a review from Copilot February 21, 2026 20:50

Copilot started reviewing on behalf of rilma February 21, 2026 20:51 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

tests/test_api.py Outdated Show resolved Hide resolved

pyiri2016/api/update.py Outdated Show resolved Hide resolved

.github/workflows/smoke.yml Outdated Show resolved Hide resolved

Update pyproject.toml

b41257b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This was referenced Feb 21, 2026

test: mock network calls in test_retrieve #41

Merged

Fix path traversal check in tar extraction to use path-aware comparison #42

Merged

rilma and others added 6 commits February 21, 2026 22:00

Update .github/workflows/smoke.yml

39e2059

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: use os.path.commonpath for path traversal check and raise ValueE…

e654ff1

…rror Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

fix: handle ValueError from os.path.commonpath for cross-drive paths

e18b276

Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

test: mock wget.download in test_retrieve to avoid network calls

e39217a

Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

test: address code review - explicit buf.seek(0) and assert mock call…

0ad436a

…ed with correct URL Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

unit-testing

f03e10a

rilma requested a review from Copilot February 21, 2026 21:10

Copilot started reviewing on behalf of rilma February 21, 2026 21:11 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

update log

51ca90e

rilma requested a review from Copilot February 21, 2026 21:22

Copilot started reviewing on behalf of rilma February 21, 2026 21:22 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

pyiri2016/api/update.py Outdated Show resolved Hide resolved

.github/workflows/smoke.yml Outdated Show resolved Hide resolved

pyiri2016/api/update.py Outdated Show resolved Hide resolved

rilma and others added 2 commits February 21, 2026 22:28

Update pyiri2016/api/update.py

c8d0cb7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update .github/workflows/smoke.yml

67a182b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Feb 21, 2026

Fix variable shadowing in is_within_directory inner function parameter #43

Merged

Fix variable shadowing in is_within_directory inner function

dfa4d22

Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

rilma requested a review from Copilot February 21, 2026 21:42

Copilot started reviewing on behalf of rilma February 21, 2026 21:42 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

.github/workflows/smoke.yml Outdated Show resolved Hide resolved

tests/test_api.py Show resolved Hide resolved

pyiri2016/api/update.py Outdated Show resolved Hide resolved

rilma and others added 3 commits February 21, 2026 22:48

Update pyproject.toml

b6f1d8b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update Makefile

3d1e664

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update .github/workflows/smoke.yml

250c619

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Feb 21, 2026

Add negative test cases for path-traversal protection in update.retrieve() #44

Merged

Copilot AI mentioned this pull request Feb 21, 2026

Fix tarfile symlink/hardlink escape in safe_extract #45

Merged

Copilot AI and others added 6 commits February 21, 2026 22:58

Add negative test cases for path-traversal protection in update.retri…

86840ed

…eve() Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

Fix tarfile symlink/hardlink escape vulnerability in safe_extract

ecd31b3

Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>

fix test cases

82316fa

fix deprecation warnings due to Latex characters

77c8b80

figures

7517370

format

6117e49

rilma merged commit 1a47c60 into main Feb 21, 2026
3 checks passed

rilma deleted the features/upgrade-ci-cd branch February 21, 2026 22:31

Conversation

rilma commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 21, 2026

Uh oh!

Copilot AI commented Feb 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 21, 2026

Uh oh!

Copilot AI commented Feb 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rilma commented Feb 21, 2026 •

edited

Loading