Fix variable shadowing in is_within_directory inner function parameter#43
Merged
rilma merged 2 commits intofeatures/upgrade-ci-cdfrom Feb 21, 2026
Merged
Fix variable shadowing in is_within_directory inner function parameter#43rilma merged 2 commits intofeatures/upgrade-ci-cdfrom
is_within_directory inner function parameter#43rilma merged 2 commits intofeatures/upgrade-ci-cdfrom
Conversation
Co-authored-by: rilma <14822065+rilma@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP to address feedback for CI/CD pipeline upgrades
Fix variable shadowing in Feb 21, 2026
is_within_directory inner function parameter
rilma
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
directoryparameter of the inner functionis_within_directoryshadowed the outerretrievefunction'sdirectoryparameter, creating ambiguity and potential for subtle bugs.Change
Renamed the inner function's parameter from
directorytobase_dir:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.