-
Notifications
You must be signed in to change notification settings - Fork 0
feat: v2.0 premium physics — yaw damping, slip discrimination, adaptive smooth, TC #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| [ABOUT] | ||
| NAME = MyGamepadFX | ||
| VERSION = 1.0 | ||
| VERSION = 2.0 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clamp live INI numeric values before assigning to
CFG.applyLiveCfg()trustslive_cfg.inivalues. Invalid values (for exampleSLIP_DELTA_THRESH <= 0orSLIP_LIMIT_RANGE <= 0) flow into divisions at Line 109 in this file andMyGamepadFX/lib.luaLine 84, producing unstable control math (Inf/NaN paths).Proposed fix
local function applyLiveCfg() local ok, ini = pcall(ac.INIConfig.load, LIVE_CFG_PATH) if not ok or not ini then return end + local function getNum(key, fallback, minV, maxV) + local v = tonumber(ini:get('PARAMS', key, fallback)) or fallback + if minV and maxV then return math.clamp(v, minV, maxV) end + if minV then return math.max(v, minV) end + if maxV then return math.min(v, maxV) end + return v + end @@ - CFG.SLIP_DELTA_THRESH = ini:get('PARAMS', 'SLIP_DELTA_THRESH', CFG.SLIP_DELTA_THRESH) + CFG.SLIP_DELTA_THRESH = getNum('SLIP_DELTA_THRESH', CFG.SLIP_DELTA_THRESH, 0.001, 1.0) @@ - CFG.SLIP_LIMIT_RANGE = ini:get('PARAMS', 'SLIP_LIMIT_RANGE', CFG.SLIP_LIMIT_RANGE) + CFG.SLIP_LIMIT_RANGE = getNum('SLIP_LIMIT_RANGE', CFG.SLIP_LIMIT_RANGE, 0.001, 1.0)🤖 Prompt for AI Agents