Merged
Conversation
Contributor
ten0s
commented
Dec 21, 2022
ten0s
commented
- Upgraded node-gyp
- Upgraded Ubuntu to 22.04
- Ported tests to Soup3
- Fixed GST tests on MacOS
Contributor
Author
|
Fixes #326 |
Closed
Owner
|
Do you wanna debug the error test? Otherwise I'm fine if we just skip it on windows, I don't have much resources to invest in this project but I'd rather have it working with inaccuracies than not working at all. We can open an issue to track the bug. |
Contributor
Author
|
I disabled a couple of tests on Mac and Windows. Windows passed. |
Owner
|
Alright, so this can be merged? The changes LGTM. Any idea why macOS is flaky during setup? |
Contributor
Author
|
It can be merged. Regarding Mac, similar issue was in Homebrew half year ago, was fixed after a while |
Owner
|
Got it. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.