Unit tests for the new odometry implementation in diff_drive_controller#2099
Merged
christophfroehlich merged 6 commits intoros-controls:masterfrom Feb 15, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2099 +/- ##
==========================================
+ Coverage 84.80% 84.86% +0.06%
==========================================
Files 151 152 +1
Lines 14836 14859 +23
Branches 1286 1286
==========================================
+ Hits 12581 12610 +29
+ Misses 1784 1778 -6
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Amronos
suggested changes
Jan 7, 2026
Contributor
Amronos
left a comment
There was a problem hiding this comment.
Thanks a lot for the tests! Some minor suggestions.
Amronos
approved these changes
Jan 8, 2026
christophfroehlich
approved these changes
Feb 15, 2026
Member
christophfroehlich
left a comment
There was a problem hiding this comment.
Thanks a lot, LGTM!
665c60c
into
ros-controls:master
13 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2033
Description
This PR adds unit tests for the
Odometryclass indiff_drive_controllerto verify the new mathematical logic introduced in #1854.Changes
test/test_odometry.cppcovering:dtCMakeLists.txtto build the new test.Testing
colcon test: 8 tests passed, 0 failures.