Skip to content

Fix open-loop odometry using unbounded commands by applying SpeedLimiter first (backport #2260)#2278

Merged
christophfroehlich merged 1 commit intokiltedfrom
mergify/bp/kilted/pr-2260
Apr 2, 2026
Merged

Fix open-loop odometry using unbounded commands by applying SpeedLimiter first (backport #2260)#2278
christophfroehlich merged 1 commit intokiltedfrom
mergify/bp/kilted/pr-2260

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Apr 2, 2026

Open-loop odometry was using raw velocity commands before SpeedLimiter,
causing it to integrate unbounded inputs.

Moved limiter application before odometry update so try_update_open_loop()
uses limited commands, aligning odometry with actual motion.

Fixes: #2250


This is an automatic backport of pull request #2260 done by Mergify.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.30%. Comparing base (6fd6ea9) to head (a9391d0).
⚠️ Report is 1 commits behind head on kilted.

Additional details and impacted files
@@           Coverage Diff           @@
##           kilted    #2278   +/-   ##
=======================================
  Coverage   85.30%   85.30%           
=======================================
  Files         151      151           
  Lines       14832    14832           
  Branches     1282     1282           
=======================================
  Hits        12653    12653           
  Misses       1725     1725           
  Partials      454      454           
Flag Coverage Δ
unittests 85.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...iff_drive_controller/src/diff_drive_controller.cpp 82.62% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 5afc9fd into kilted Apr 2, 2026
15 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/kilted/pr-2260 branch April 2, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants