Fix open-loop odometry using unbounded commands by applying SpeedLimiter first (backport #2260)#2278
Merged
christophfroehlich merged 1 commit intokiltedfrom Apr 2, 2026
Merged
Conversation
(cherry picked from commit 7c64f3a)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## kilted #2278 +/- ##
=======================================
Coverage 85.30% 85.30%
=======================================
Files 151 151
Lines 14832 14832
Branches 1282 1282
=======================================
Hits 12653 12653
Misses 1725 1725
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open-loop odometry was using raw velocity commands before SpeedLimiter,
causing it to integrate unbounded inputs.
Moved limiter application before odometry update so try_update_open_loop()
uses limited commands, aligning odometry with actual motion.
Fixes: #2250
This is an automatic backport of pull request #2260 done by Mergify.