Skip to content

proposal for chaning nodlet pkg/type name#21

Open
k-okada wants to merge 1 commit intoindigofrom
change_nodolet_type
Open

proposal for chaning nodlet pkg/type name#21
k-okada wants to merge 1 commit intoindigofrom
change_nodolet_type

Conversation

@k-okada
Copy link
Copy Markdown
Contributor

@k-okada k-okada commented Aug 23, 2016

format of nodelet_plugins.xml is

  <class name="example_pkg/MyNodeletClass" type="example_pkg::MyNodeletClass" base_class_type="nodelet::Nodelet">

http://wiki.ros.org/nodelet/Tutorials/Porting%20nodes%20to%20nodelets

If someonf is using nodelet already, this breaks API

@iory

@k-okada k-okada force-pushed the change_nodolet_type branch from 29b7679 to 48e6a67 Compare August 23, 2016 16:35
@iory
Copy link
Copy Markdown
Contributor

iory commented Aug 23, 2016

+1 to me

@wkentaro
Copy link
Copy Markdown
Member

I agree with this change.
But this breaks the nodelet API, so I think you should release a version before merging this, and release a major version afterward.

@wkentaro
Copy link
Copy Markdown
Member

See #59, it won't break API and just rename the nodelets.
We can break API after releasing the new API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants