Need to add hpp headers to valid extensions even when not provided via options#84
Open
lucasw wants to merge 2 commits intoros:masterfrom
Open
Need to add hpp headers to valid extensions even when not provided via options#84lucasw wants to merge 2 commits intoros:masterfrom
lucasw wants to merge 2 commits intoros:masterfrom
Conversation
lucasw
force-pushed
the
add_headers_to_valid_extensions
branch
from
73013e6 to
6bca272
Compare
lucasw
force-pushed
the
add_headers_to_valid_extensions
branch
from
6bca272 to
b8a1e5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#82 removed '.h' from valid extensions and only header extensions via
--headers...caused extensions to be added onto it.This is what was happening with no --headers option provided:
If I manually set the header file types it then worked:
(didn't look too hard but previously only h was in valid extensions and not hpp or hxx, it was supposed to match on the first character h so hpp and hxx still worked- but that didn't work or wasn't ever implemented- or was broken in another commit from further back?)
So here the _hpp_headers is added to valid extensions after the processing of options has a chance to modify it, so either the default hpp header or the modified ones get added.