Skip to content

Need to add hpp headers to valid extensions even when not provided via options #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucasw wants to merge 2 commits into
base: master
Choose a base branch
from
+141 −46
Open

Need to add hpp headers to valid extensions even when not provided via options #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef980d
Update pycodestyle.py to latest 2.7.0
lucasw Sep 8, 2021
b8a1e5c
Need to add hpp headers to valid extension when they are and aren't p…
lucasw Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/roslint/cpplint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,8 +575,6 @@ def ProcessHppHeadersOption(val):
global _hpp_headers
try:
_hpp_headers = set(val.split(','))
# Automatically append to extensions list so it does not have to be set 2 times
_valid_extensions.update(_hpp_headers)
except ValueError:
PrintUsage('Header extensions must be comma separated list.')

Expand Down Expand Up @@ -6028,6 +6026,9 @@ def ProcessConfigOverrides(filename):
for filter in reversed(cfg_filters):
_AddFilters(filter)

# These are either the default headers or were modified above by options
_valid_extensions.update(_hpp_headers)

return True


Expand Down
Loading