Skip to content

docs: Point pr-review fixer at migrated github-pr-review skill - #49

Merged
rubambiza merged 1 commit into
rossoctl:mainfrom
rubambiza:fix/pr-review-source-agent-skills
Aug 10, 2026
Merged

docs: Point pr-review fixer at migrated github-pr-review skill#49
rubambiza merged 1 commit into
rossoctl:mainfrom
rubambiza:fix/pr-review-source-agent-skills

Conversation

@rubambiza

Copy link
Copy Markdown
Contributor

Summary

Points the pr-review fixer at the migrated github-pr-review skill in rossoctl/agent-skills, replacing the former github:pr-review skill that lived in rossoctl/rossoctl/.claude/skills/. This is unit 2 of the skill-migration epic rossoctl/rossoctl#2149; the skill landed in agent-skills via rossoctl/agent-skills#28.

Updates standing-orders/pr-review.md:

  • Scope + Cron jobs now reference github-pr-review sourced from the agent-skills checkout.
  • Adds a Skill Source subsection documenting the on-host checkout path, that the wiring lives in the fixer cron payload (updated via openclaw cron edit, never by hand-editing jobs.json), and the checkout-currency requirement.

The live fixer cron payload is repointed separately on the runner (operational step). The former skill is intentionally left in place in rossoctl/rossoctl until post-rewire monitoring confirms no review degradation (see #2149), keeping a one-step rollback.

Fixes #26

Assisted-By: Claude Code

Update the standing order to reflect that the fixer now sources the
github-pr-review skill from the agent-skills checkout (the migrated,
version-controlled skill) instead of the former github:pr-review skill
in rossoctl/rossoctl/.claude/skills/. Documents the cron payload wiring
and the checkout-currency requirement.

Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com>

Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
@rubambiza rubambiza added the ready-for-ai-review Request automated AI code review from clawgenti label Aug 10, 2026

@clawgenti clawgenti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only update that replaces two references to the old github:pr-review skill name with github-pr-review and adds a concise Skill Source subsection documenting the on-host agent-skills checkout path, cron payload wiring, and openclaw cron edit usage — all accurate and consistent with the migrated skill.

All checks pass. Ready for human review.


Reviewed by clawgenti using github:pr-review

@rubambiza rubambiza self-assigned this Aug 10, 2026
@rubambiza rubambiza added ready-for-human-review AI review passed, ready for human reviewer and removed ready-for-ai-review Request automated AI code review from clawgenti labels Aug 10, 2026

@cwiklik cwiklik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean docs pointer for the skill migration (epic #2149, unit 2). I verified the cross-repo references:

  • skills/github-pr-review/SKILL.md exists in rossoctl/agent-skills — the documented path agent-skills/skills/github-pr-review/SKILL.md is correct.
  • agent-skills#28 ("Migrate github-pr-review skill from rossoctl/rossoctl") is merged.
  • The former github:pr-review skill is still present in rossoctl/rossoctl/.claude/skills/, matching the doc's "intentionally left in place until post-rewire monitoring" note.

The "Skill Source" subsection is a good addition — documenting that wiring lives in the fixer cron payload (openclaw cron edit, never hand-editing jobs.json) and the checkout-currency requirement. Correctly scoped: the live cron repoint is called out as a separate operational step, so the doc describes the target state without implying the runner is already switched.

Docs-only, DCO green, signed. LGTM.

Assisted-By: Claude Code

@rubambiza
rubambiza merged commit da0b85b into rossoctl:main Aug 10, 2026
1 check passed
@rubambiza
rubambiza deleted the fix/pr-review-source-agent-skills branch August 10, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review AI review passed, ready for human reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Realign pr-review standing order to source skill from agent-skills

3 participants