Feature/249 support geoparquet#254
Open
nathanjmcdougall wants to merge 11 commits intorstudio:mainfrom
Open
Conversation
This was referenced Jul 20, 2024
Merged
Contributor
Author
|
The pipeline failed but it seems just to be an intermittent networking issue, from the raw logs
|
isabelizimm
reviewed
Jul 23, 2024
isabelizimm
reviewed
Jul 23, 2024
701248d to
da71966
Compare
Merged
Contributor
Author
|
@isabelizimm thanks for merging that adaptor PR, whew! I have refactored this PR to use a new GeoPandas adaptor. It looks like the CI is failing due to databricks auth issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve #249.
I am developing on Windows so adding a dependency and updating the requirements file is a little cumbersome.
The way I approached this is to use
uvwithuv pip compile setup.cfg --extra=doc --extra=test --python-platform=linux --output-file=requirements/dev.txt --unsafe-package=pip --unsafe-package=setuptoolsAnd then I did some massaging of the diff to remove some unnecessary stylistic changes introduced by uv.
Also pip-compile ignores platform specifiers, so
uvdidn't includeappnope==0.1.4(it is a Darwin-only dependency ofipykernel), but I manually added it back to minimize the diff.This might be an argument in favour of switching to
uv pip compileoverpip-compilebut it also might be an argument in favour of me developing on Linux 👀