This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Remove deprecated Error::description#283
Closed
AnderEnder wants to merge 2 commits intorust-lang-deprecated:masterfrom
Closed
Remove deprecated Error::description#283AnderEnder wants to merge 2 commits intorust-lang-deprecated:masterfrom
AnderEnder wants to merge 2 commits intorust-lang-deprecated:masterfrom
Conversation
AnderEnder
force-pushed
the
remove-deprecated-error-description
branch
from
9b942bd to
2587bc9
Compare
Contributor
|
That's quite the leap in minimum supported rust. Do the tests fail on 1.13? |
Contributor
|
I dug into this and sure enough, with 1.41 release, our next breaking version would need to support 1.27 at minimum or error in compilation. An alternative option would be to https://crates.io/crates/rustversion conditionally compile the trait. |
Contributor
Author
|
@AndyGauge, there is another option: to allow deprecated methods. |
This was referenced Dec 30, 2019
Contributor
Author
|
Closing in favour of #285 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error::descriptionhas been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon.This PR:
descriptioninimpl ::std::error::Errorforeign_link_variantRelated PR: rust-lang/rust#66919