Use Error::description only for rust below 1.42#285
Conversation
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
There was a problem hiding this comment.
From your three PRs, I think this is the best solution and what we should do! I only left one inline comment.
AnderEnder
force-pushed
the
conditional-macro-error-description
branch
from
fd24f31 to
6ff71d8
Compare
|
I'm a fan of this approach. |
| #[doc(hidden)] | ||
| #[cfg(not(has_error_description_deprecated))] | ||
| #[macro_export(local_inner_macros)] | ||
| macro_rules! call_to_deprecated_description { | ||
| ($e:ident) => { ::std::error::Error::description($e) }; | ||
| } |
There was a problem hiding this comment.
Doesn't this need a doc comment, too? Wouldn't #![deny(missing_documentation)] trigger in case not(has_error_description_deprecated)?
There was a problem hiding this comment.
That's why CI fails.
There was a problem hiding this comment.
Tested, it fails and reverted it back
AnderEnder
force-pushed
the
conditional-macro-error-description
branch
from
6ff71d8 to
11dd09a
Compare
AnderEnder
force-pushed
the
conditional-macro-error-description
branch
from
11dd09a to
c1018b6
Compare
|
Any chance of a release containing this fix? Thanks |
|
Yeah, give me a week or two, but I will release it. |
|
@AndyGauge Ping regarding release. People start noticing this on stable (#286). Thanks! :) |
|
shoot you are right, I'm behind on this. Tomorrow. |
|
🎉 0.12.2 is on crates.io Let me know if it breaks production 😉 |
4 participants
Error::descriptionhas been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon (1.42)This PR:
has_error_description_deprecatedimpl_error_chain_kindwithout usage ofError::descriptionRelated PR: rust-lang/rust#66919
Alternative PR(with removed description): #283