Add basic getsockopt shim for reading SO_ERROR#5005
Add basic getsockopt shim for reading SO_ERROR#5005RalfJung merged 1 commit intorust-lang:masterfrom
getsockopt shim for reading SO_ERROR#5005Conversation
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
This comment has been minimized.
This comment has been minimized.
c2fe5a4 to
8b09c4b
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
There was a problem hiding this comment.
Amazing how everything is coming together and now we can actually run that Tokio smoke test. :)
I still have some comments though, of course. ;)
@rustbot author
|
Reminder, once the PR becomes ready for a review, use |
|
@rustbot ready |
There was a problem hiding this comment.
That truncation of the value is really annoying, we may have to iterate a bit until we find a good way to deal with that.
@rustbot author
|
I think if you restart the failed CI job then everything should be fine. @rustbot ready |
There was a problem hiding this comment.
Very nice. :)
Just one last question. Please also squash the commits.
@rustbot author
fbefc74 to
378a643
Compare
|
@rustbot ready |
Hi,
This pull request adds the
getsockoptshim. Currently, it only supports reading theSO_ERRORoption.By this, Miri is now able to run programs which use tokio/mio sockets. Thus, I also added a simple tokio socket test which tests connecting/accepting and reading/writing. Let me know if I should test more things with the tokio sockets.
I've also ran the tokio TCP test suite and we pass everything except:
For the latter two points I'll soon open pull requests here.