Always build with mimalloc on windows#22495
Open
Veykril wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
| return None; | ||
| } | ||
| let malloc = if self.mimalloc { | ||
| let malloc = if self.mimalloc || cfg!(windows) { |
Contributor
There was a problem hiding this comment.
I don't think this is the place to do that. Instead we should change how we build our distributed server.
Member
Author
There was a problem hiding this comment.
Then I need to annoyingly remember to pass the flag every time I cargo xtask install. Especially with us not shipping debug info I will likely run this way more often now than not as I'll likely depend on self-built servers more
Contributor
There was a problem hiding this comment.
We can make it the default, but not allowing to build without mimalloc seems excessive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is vastly faster than the system allocator for our workload on windows. We tend to allocate a lot of small objects on differing threads which causes the system allocator lock to contend and block a lot.