Skip to content

Always build with mimalloc on windows #22495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Veykril wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Always build with mimalloc on windows #22495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xtask/src/flags.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ impl Install {
if (self.client || self.proc_macro_server) && !self.server {
return None;
}
let malloc = if self.mimalloc {
let malloc = if self.mimalloc || cfg!(windows) {
Copy link
Copy Markdown
Contributor

@ChayimFriedman2 ChayimFriedman2 May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the place to do that. Instead we should change how we build our distributed server.

Copy link
Copy Markdown
Member Author

@Veykril Veykril Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I need to annoyingly remember to pass the flag every time I cargo xtask install. Especially with us not shipping debug info I will likely run this way more often now than not as I'll likely depend on self-built servers more

Copy link
Copy Markdown
Contributor

@ChayimFriedman2 ChayimFriedman2 Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make it the default, but not allowing to build without mimalloc seems excessive.

Malloc::Mimalloc
} else if self.jemalloc {
Malloc::Jemalloc
Expand Down
Loading