Remove support for slugs in diagnostic messages #152250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
convert_finish
branch
from
a62c29e to
7def0c4
Compare
3 tasks
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
convert_finish
branch
from
7def0c4 to
8b76776
Compare
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
convert_finish
branch
from
8b76776 to
d24b1cc
Compare
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
convert_finish
branch
from
d24b1cc to
7c36a05
Compare
JonathanBrouwer
force-pushed
the
convert_finish
branch
from
7c36a05 to
81d4214
Compare
JonathanBrouwer
changed the title
rustbot
added
the
S-waiting-on-review
Collaborator
|
cc @davidtwco, @TaKO8Ki
cc @davidtwco, @TaKO8Ki
cc @davidtwco, @TaKO8Ki |
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @fmease rustbot has assigned @fmease. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
r? @jdonszelmann |
Contributor
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 8, 2026
…jdonszelmann Remove support for slugs in diagnostic messages This PR contains 5 commits, and is best reviewed commit-by-commit: - rust-lang@ea87331 Removes support from slugs from `rustc_errors` - rust-lang@62dd371 Removes support from slugs from `rustc_macros` (which declares `derive(Diagnostic)`) - rust-lang@2289e6c Adjuist the `ui-fulldeps` testsuite to match the changes in `rustc_macros` - rust-lang@0db0acd Removes support for the fallback bundle (which previously contained all messages, but is now empty) from `rustc_driver_impl` and `rustc_session` - rust-lang@81d4214 Removes an integration test that tested the translation system using fluent
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 8, 2026
…uwer Rollup of 7 pull requests Successful merges: - #151455 (Fix `SourceFile::normalized_byte_pos`) - #152250 (Remove support for slugs in diagnostic messages) - #152322 (Replace some `feature(core_intrinsics)` with stable hints) - #152328 (Fix a few diagnostics) - #151640 (Cleanup offload datatransfer) - #152212 (Port some attributes to the attr parser) - #152309 (Fix bound var resolution for trait aliases)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 8, 2026
…jdonszelmann Remove support for slugs in diagnostic messages This PR contains 5 commits, and is best reviewed commit-by-commit: - rust-lang@ea87331 Removes support from slugs from `rustc_errors` - rust-lang@62dd371 Removes support from slugs from `rustc_macros` (which declares `derive(Diagnostic)`) - rust-lang@2289e6c Adjuist the `ui-fulldeps` testsuite to match the changes in `rustc_macros` - rust-lang@0db0acd Removes support for the fallback bundle (which previously contained all messages, but is now empty) from `rustc_driver_impl` and `rustc_session` - rust-lang@81d4214 Removes an integration test that tested the translation system using fluent
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 8, 2026
…uwer Rollup of 8 pull requests Successful merges: - #151455 (Fix `SourceFile::normalized_byte_pos`) - #152250 (Remove support for slugs in diagnostic messages) - #152322 (Replace some `feature(core_intrinsics)` with stable hints) - #151640 (Cleanup offload datatransfer) - #152212 (Port some attributes to the attr parser) - #152309 (Fix bound var resolution for trait aliases) - #152339 (diagnostics: fix ICE in closure signature mismatch) - #152341 (`cfg_select!`: allow optional comma after `{ /* ... */ }`)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 8, 2026
…uwer Rollup of 9 pull requests Successful merges: - #151455 (Fix `SourceFile::normalized_byte_pos`) - #152250 (Remove support for slugs in diagnostic messages) - #152322 (Replace some `feature(core_intrinsics)` with stable hints) - #152328 (Fix a few diagnostics) - #151640 (Cleanup offload datatransfer) - #152212 (Port some attributes to the attr parser) - #152309 (Fix bound var resolution for trait aliases) - #152339 (diagnostics: fix ICE in closure signature mismatch) - #152341 (`cfg_select!`: allow optional comma after `{ /* ... */ }`)
Member
|
This is missing the rustc-dev-guide changes from #152137. |
Contributor
Author
|
Good spot, I'll commit those directly to the rustc-dev-guide, thanks! |
rust-timer
added a commit
that referenced
this pull request
Feb 8, 2026
Rollup merge of #152250 - JonathanBrouwer:convert_finish, r=jdonszelmann Remove support for slugs in diagnostic messages This PR contains 5 commits, and is best reviewed commit-by-commit: - ea87331 Removes support from slugs from `rustc_errors` - 62dd371 Removes support from slugs from `rustc_macros` (which declares `derive(Diagnostic)`) - 2289e6c Adjuist the `ui-fulldeps` testsuite to match the changes in `rustc_macros` - 0db0acd Removes support for the fallback bundle (which previously contained all messages, but is now empty) from `rustc_driver_impl` and `rustc_session` - 81d4214 Removes an integration test that tested the translation system using fluent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 5 commits, and is best reviewed commit-by-commit:
rustc_errorsrustc_macros(which declaresderive(Diagnostic))ui-fulldepstestsuite to match the changes inrustc_macrosrustc_driver_implandrustc_session