Rollup of 4 pull requests #152274

JonathanBrouwer · 2026-02-07T08:41:08Z

Successful merges:

Add avr_target_feature #146900 (Add avr_target_feature)
Port symbol mangler attrs #150949 (Port symbol mangler attrs)
Convert diagnostic style checks #152252 (Convert diagnostic style checks)
Use .map.collect to aggregate in .to_ty of tuples #152265 (Use .map.collect to aggregate in .to_ty of tuples)

@Patryk27

…ingjubilee Add avr_target_feature This adds the following unstable target features (tracking issue: rust-lang#146889): - The following two are particularly important for properly supporting inline assembly: - `tinyencoding`: AVR has devices that reduce the number of registers, similar to RISC-V's RV32E. This feature is necessary to support inline assembly in such devices. (see also rust-lang#146901) - `lowbytefirst`: AVR's memory access is per 8-bit, and when writing 16-bit ports, the bytes must be written in a specific order. This order depends on devices, making this feature necessary to write proper inline assembly for such use cases. (see also llvm/llvm-project@2a52876) - The followings help recognizing whether specific instructions are available: - `addsubiw` - `break` - `eijmpcall` - `elpm` - `elpmx` - `ijmpcall` - `jmpcall` - `lpm` - `lpmx` - `movw` - `mul` - `rmw` - `spm` - `spmx` Of these, all except `addsubiw`, `break`, `ijmpcall`, `lpm`, `rmw`, `spm`, and `spmx` have [corresponding conditional codes in avr-libc](https://github.com/search?q=repo%3Aavrdudes%2Favr-libc+%2F__AVR_HAVE_%2F&type=code&p=1). LLVM also has `des` feature, but I excluded it from this PR because [DES](https://en.wikipedia.org/wiki/Data_Encryption_Standard) is insecure. - Report future-incompatible warning (rust-lang#116344) for -C target-feature=-sram and -C target-cpu=<device_without_sram> cases because SRAM is minimum requirement for non-assembly language in both avr-gcc and LLVM. - See rust-lang#146900 (comment) for details. LLVM also has `smallstack`, `wrappingrjmp`, and `memmappedregs` features, but I skipped them because they didn't seem to belong to either of the above categories, but I might have missed something. (The feature names are match with [definitions in LLVM](https://github.com/llvm/llvm-project/blob/llvmorg-21.1.0/llvm/lib/Target/AVR/AVRDevices.td).) cc @Patryk27 @Rahix r? workingjubilee @rustbot label +O-AVR +A-target-feature

@JonathanBrouwer

… r=jdonszelmann,JonathanBrouwer Port symbol mangler attrs Tracking issue: rust-lang#131229 @JonathanBrouwer could you run perf on this?

@jdonszelmann

…r=jdonszelmann Convert diagnostic style checks For rust-lang#151366 r? @jdonszelmann

Use `.map.collect` to aggregate in `.to_ty` of tuples Since rust-lang#48994 might have been resolved, we can address the FIXME.

JonathanBrouwer · 2026-02-07T08:41:16Z

@bors r+ rollup=never p=5

rust-bors · 2026-02-07T08:41:19Z

📌 Commit 5e476ba has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-02-07T12:06:07Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 10m 3s
Pushing 06cafcb to main...

rust-timer · 2026-02-07T12:07:16Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#146900	Add avr_target_feature	`0f3ec27a813035115098ec25777ada19bba9bc23` (link)
#150949	Port symbol mangler attrs	`0584b5b89c9318a830c5a481c570fc5c86bf621c` (link)
#152252	Convert diagnostic style checks	`cb01915fd3e9e6c26442957c2707fef9a753f515` (link)
#152265	Use `.map.collect` to aggregate in `.to_ty` of tuples	`2cb05601d5d13e55160ec48097e7e8f20c7d2fd6` (link)

previous master: 56aaf58ec0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-02-07T12:09:07Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 56aaf58 (parent) -> 06cafcb (this PR)

Test differences

Show 25 test diffs

Stage 1

[ui] tests/ui/abi/avr-sram.rs#disable_sram: [missing] -> pass (J0)
[ui] tests/ui/abi/avr-sram.rs#has_sram: [missing] -> pass (J0)
[ui] tests/ui/abi/avr-sram.rs#no_sram: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/abi/avr-sram.rs#disable_sram: [missing] -> ignore (gcc backend is marked as ignore) (J1)
[ui] tests/ui/abi/avr-sram.rs#has_sram: [missing] -> ignore (gcc backend is marked as ignore) (J1)
[ui] tests/ui/abi/avr-sram.rs#no_sram: [missing] -> ignore (gcc backend is marked as ignore) (J1)
[ui] tests/ui/abi/avr-sram.rs#disable_sram: [missing] -> pass (J2)
[ui] tests/ui/abi/avr-sram.rs#has_sram: [missing] -> pass (J2)
[ui] tests/ui/abi/avr-sram.rs#no_sram: [missing] -> pass (J2)

Additionally, 16 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 06cafcbe08b1b0d4235685abd5f817ae1979cefa --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

i686-gnu-nopt-1: 2h 6m -> 2h 59m (+41.4%)
dist-x86_64-apple: 2h 13m -> 1h 41m (-24.3%)
aarch64-apple: 2h 30m -> 3h 4m (+22.6%)
i686-gnu-2: 1h 29m -> 1h 49m (+21.6%)
x86_64-gnu-miri: 1h 11m -> 1h 21m (+14.4%)
pr-check-2: 35m 32s -> 40m 30s (+14.0%)
i686-gnu-1: 2h 7m -> 2h 24m (+13.7%)
x86_64-gnu-llvm-21-1: 1h 7m -> 1h 15m (+12.9%)
pr-check-1: 27m 27s -> 31m (+12.9%)
dist-powerpc64-linux-musl: 1h 28m -> 1h 39m (+12.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-02-07T12:49:00Z

Finished benchmarking commit (06cafcb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.5%, secondary -5.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.3%	[-6.2%, -4.4%]	2
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Cycles

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-2.9%, -2.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.618s -> 473.906s (0.06%)
Artifact size: 398.00 MiB -> 397.97 MiB (-0.01%)

taiki-e and others added 12 commits February 5, 2026 19:58

Add avr_target_feature

8cbc623

Require sram target feature on AVR

895ea0c

Port #[rustc_symbol_name] and #[rustc_def_path] to attr parser

10f0c2d

Use .map.collect to aggregate in .to_ty of tuples

b5cd820

Remove tidy fluent file checks

f71347c

Check style of messages in rustc_macros

ca9c227

Fix existing messages in the diag structs

edd43c9

Fix existing messages in stderrs

c1091da

Rollup merge of rust-lang#150949 - Bryntet:port_symbol_mangler_attrs,…

defc1d7

… r=jdonszelmann,JonathanBrouwer Port symbol mangler attrs Tracking issue: rust-lang#131229 @JonathanBrouwer could you run perf on this?

Rollup merge of rust-lang#152252 - JonathanBrouwer:port-tidy-checks, …

723eb92

…r=jdonszelmann Convert diagnostic style checks For rust-lang#151366 r? @jdonszelmann

Rollup merge of rust-lang#152265 - lapla-cogito:tytuple_agg, r=Zalathar

5e476ba

Use `.map.collect` to aggregate in `.to_ty` of tuples Since rust-lang#48994 might have been resolved, we can address the FIXME.

rust-bors bot added the rollup A PR which is a rollup label Feb 7, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2026

rust-bors bot merged commit 06cafcb into rust-lang:main Feb 7, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Feb 7, 2026

This was referenced Feb 7, 2026

Port rustc_intrinsic_const_stable_indirect and rustc_intrinsic to the new attribute parser #152168

Merged

Port some attributes to the attr parser #152212

Merged

Rollup of 9 pull requests #152279

Closed

This was referenced Feb 7, 2026

asm! support for the Xtensa architecture #147302

Open

Check tainted_by_error in LateLint #147876

Open

Port rustc_strict_coherence to the new attribute parser #152171

Merged

Remove support for slugs in diagnostic messages #152250

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 4 pull requests #152274

Rollup of 4 pull requests #152274

Uh oh!

JonathanBrouwer commented Feb 7, 2026

Uh oh!

JonathanBrouwer commented Feb 7, 2026

Uh oh!

rust-bors bot commented Feb 7, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 7, 2026

Uh oh!

Uh oh!

rust-timer commented Feb 7, 2026

Uh oh!

github-actions bot commented Feb 7, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Feb 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Rollup of 4 pull requests #152274

Rollup of 4 pull requests #152274

Uh oh!

Conversation

JonathanBrouwer commented Feb 7, 2026

Uh oh!

JonathanBrouwer commented Feb 7, 2026

Uh oh!

rust-bors bot commented Feb 7, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 7, 2026

Uh oh!

Uh oh!

rust-timer commented Feb 7, 2026

Uh oh!

github-actions bot commented Feb 7, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Feb 7, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants